Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/html_viewer/setup.cc

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback from sky Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/ax_provider_impl_unittest.cc ('k') | content/app/content_main_runner.cc » ('j') | content/browser/child_process_launcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/html_viewer/setup.cc
diff --git a/components/html_viewer/setup.cc b/components/html_viewer/setup.cc
index 74a53b8781d905b16c6df8e908ff73874ae8a5de..c4bf6cdb0ae17b6cc0cfb3d546ca002b29ae9e95 100644
--- a/components/html_viewer/setup.cc
+++ b/components/html_viewer/setup.cc
@@ -108,11 +108,12 @@ void Setup::InitIfNecessary(const gfx::Size& screen_size_in_pixels,
renderer_scheduler_ = scheduler::RendererScheduler::Create();
blink_platform_.reset(new BlinkPlatformImpl(app_, renderer_scheduler_.get()));
#if defined(V8_USE_EXTERNAL_STARTUP_DATA)
- CHECK(gin::V8Initializer::LoadV8SnapshotFromFD(
- resource_loader_.ReleaseFile(kResourceNativesBlob).TakePlatformFile(), 0u,
- 0u,
+ gin::V8Initializer::LoadV8SnapshotFromFD(
resource_loader_.ReleaseFile(kResourceSnapshotBlob).TakePlatformFile(),
- 0u, 0u));
+ 0u, 0u);
+ gin::V8Initializer::LoadV8NativesFromFD(
+ resource_loader_.ReleaseFile(kResourceNativesBlob).TakePlatformFile(), 0u,
+ 0u);
#endif
blink::initialize(blink_platform_.get());
base::i18n::InitializeICUWithFileDescriptor(
« no previous file with comments | « components/html_viewer/ax_provider_impl_unittest.cc ('k') | content/app/content_main_runner.cc » ('j') | content/browser/child_process_launcher.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698