ash/shell/content_client/shell_content_browser_client.h - Issue 1164483003: Allow startup with missing V8 snapshot file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/content_client/shell_content_browser_client.h

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reinstate asserts that the natives are passed to the renderer by fd Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/shell/content_client/shell_content_browser_client.h

diff --git a/ash/shell/content_client/shell_content_browser_client.h b/ash/shell/content_client/shell_content_browser_client.h

index 9ee3373f907959048a81e2645535dd70abb25d49..3603c939e261719108d2a8a2fdeb3ed0f58af8bf 100644

--- a/ash/shell/content_client/shell_content_browser_client.h

+++ b/ash/shell/content_client/shell_content_browser_client.h

@@ -48,6 +48,8 @@ class ShellContentBrowserClient : public content::ContentBrowserClient {

#if defined(OS_POSIX) && !defined(OS_MACOSX)

base::ScopedFD v8_natives_fd_;

base::ScopedFD v8_snapshot_fd_;

+ bool natives_fd_exists() { return v8_natives_fd_ != -1; }

sky 2015/06/04 19:36:42 fields than members. Also, can't you use v8_native

Erik Corry Chromium.org 2015/06/05 13:15:16 Done.

+ bool snapshot_fd_exists() { return v8_snapshot_fd_ != -1; }

#endif

ShellBrowserMainParts* shell_browser_main_parts_;