Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: gin/public/isolate_holder.h

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gin/public/isolate_holder.h
diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h
index 111fde870f79af3979ab494317ef7c102f8b9126..f257bded70b629c50266cfde873c7121b6a802ff 100644
--- a/gin/public/isolate_holder.h
+++ b/gin/public/isolate_holder.h
@@ -40,9 +40,9 @@ class GIN_EXPORT IsolateHolder {
// Should be invoked once before creating IsolateHolder instances to
// initialize V8 and Gin. In case V8_USE_EXTERNAL_STARTUP_DATA is
- // defined, V8's initial snapshot should be loaded (by calling
- // V8Initializer::LoadV8SnapshotFromFD or
- // V8Initializer::LoadV8Snapshot) before calling this method.
+ // defined, V8's initial natives should be loaded (by calling
+ // V8Initializer::LoadV8NativesFromFD or
+ // V8Initializer::LoadV8Natives) before calling this method.
rmcilroy 2015/06/01 14:06:31 Also mention that snapshot should be loaded if ava
Erik Corry Chromium.org 2015/06/02 11:18:52 Done.
static void Initialize(ScriptMode mode,
v8::ArrayBuffer::Allocator* allocator);

Powered by Google App Engine
This is Rietveld 408576698