Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Side by Side Diff: chromecast/browser/cast_content_browser_client.h

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add natives_fd_exists and snapshot_fd_exists instead of checking for -1 Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 5 #ifndef CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
6 #define CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 6 #define CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 // Creates a CrashHandlerHost instance for the given process type. 124 // Creates a CrashHandlerHost instance for the given process type.
125 breakpad::CrashHandlerHostLinux* CreateCrashHandlerHost( 125 breakpad::CrashHandlerHostLinux* CreateCrashHandlerHost(
126 const std::string& process_type); 126 const std::string& process_type);
127 127
128 // A static cache to hold crash_handlers for each process_type 128 // A static cache to hold crash_handlers for each process_type
129 std::map<std::string, breakpad::CrashHandlerHostLinux*> crash_handlers_; 129 std::map<std::string, breakpad::CrashHandlerHostLinux*> crash_handlers_;
130 #endif 130 #endif
131 131
132 base::ScopedFD v8_natives_fd_; 132 base::ScopedFD v8_natives_fd_;
133 base::ScopedFD v8_snapshot_fd_; 133 base::ScopedFD v8_snapshot_fd_;
134 bool natives_fd_exists() { return v8_natives_fd_ != -1; }
135 bool snapshot_fd_exists() { return v8_snapshot_fd_ != -1; }
134 136
135 scoped_ptr<URLRequestContextFactory> url_request_context_factory_; 137 scoped_ptr<URLRequestContextFactory> url_request_context_factory_;
136 138
137 DISALLOW_COPY_AND_ASSIGN(CastContentBrowserClient); 139 DISALLOW_COPY_AND_ASSIGN(CastContentBrowserClient);
138 }; 140 };
139 141
140 } // namespace shell 142 } // namespace shell
141 } // namespace chromecast 143 } // namespace chromecast
142 144
143 #endif // CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_ 145 #endif // CHROMECAST_BROWSER_CAST_CONTENT_BROWSER_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698