Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: gin/shell_runner_unittest.cc

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix misplaced ifdef for Windows Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « gin/shell/gin_main.cc ('k') | gin/test/file_runner.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gin/shell_runner.h" 5 #include "gin/shell_runner.h"
6 6
7 #include "base/compiler_specific.h" 7 #include "base/compiler_specific.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "gin/array_buffer.h" 9 #include "gin/array_buffer.h"
10 #include "gin/converter.h" 10 #include "gin/converter.h"
(...skipping 11 matching lines...) Expand all
22 using v8::String; 22 using v8::String;
23 23
24 namespace gin { 24 namespace gin {
25 25
26 TEST(RunnerTest, Run) { 26 TEST(RunnerTest, Run) {
27 base::MessageLoop message_loop; 27 base::MessageLoop message_loop;
28 std::string source = "this.result = 'PASS';\n"; 28 std::string source = "this.result = 'PASS';\n";
29 29
30 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 30 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
31 gin::V8Initializer::LoadV8Snapshot(); 31 gin::V8Initializer::LoadV8Snapshot();
32 gin::V8Initializer::LoadV8Natives();
32 #endif 33 #endif
33 34
34 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode, 35 gin::IsolateHolder::Initialize(gin::IsolateHolder::kStrictMode,
35 gin::ArrayBufferAllocator::SharedInstance()); 36 gin::ArrayBufferAllocator::SharedInstance());
36 gin::IsolateHolder instance; 37 gin::IsolateHolder instance;
37 38
38 ShellRunnerDelegate delegate; 39 ShellRunnerDelegate delegate;
39 Isolate* isolate = instance.isolate(); 40 Isolate* isolate = instance.isolate();
40 ShellRunner runner(&delegate, isolate); 41 ShellRunner runner(&delegate, isolate);
41 Runner::Scope scope(&runner); 42 Runner::Scope scope(&runner);
42 runner.Run(source, "test_data.js"); 43 runner.Run(source, "test_data.js");
43 44
44 std::string result; 45 std::string result;
45 EXPECT_TRUE(Converter<std::string>::FromV8(isolate, 46 EXPECT_TRUE(Converter<std::string>::FromV8(isolate,
46 runner.global()->Get(StringToV8(isolate, "result")), 47 runner.global()->Get(StringToV8(isolate, "result")),
47 &result)); 48 &result));
48 EXPECT_EQ("PASS", result); 49 EXPECT_EQ("PASS", result);
49 } 50 }
50 51
51 } // namespace gin 52 } // namespace gin
OLDNEW
« no previous file with comments | « gin/shell/gin_main.cc ('k') | gin/test/file_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698