Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(928)

Side by Side Diff: gin/public/isolate_holder.h

Issue 1164483003: Allow startup with missing V8 snapshot file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_ 5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_
6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_ 6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
(...skipping 22 matching lines...) Expand all
33 kSingleThread, 33 kSingleThread,
34 kUseLocker 34 kUseLocker
35 }; 35 };
36 36
37 IsolateHolder(); 37 IsolateHolder();
38 explicit IsolateHolder(AccessMode access_mode); 38 explicit IsolateHolder(AccessMode access_mode);
39 ~IsolateHolder(); 39 ~IsolateHolder();
40 40
41 // Should be invoked once before creating IsolateHolder instances to 41 // Should be invoked once before creating IsolateHolder instances to
42 // initialize V8 and Gin. In case V8_USE_EXTERNAL_STARTUP_DATA is 42 // initialize V8 and Gin. In case V8_USE_EXTERNAL_STARTUP_DATA is
43 // defined, V8's initial snapshot should be loaded (by calling 43 // defined, V8's initial natives should be loaded (by calling
44 // V8Initializer::LoadV8SnapshotFromFD or 44 // V8Initializer::LoadV8NativesFromFD or
45 // V8Initializer::LoadV8Snapshot) before calling this method. 45 // V8Initializer::LoadV8Natives) before calling this method.
rmcilroy 2015/06/01 14:06:31 Also mention that snapshot should be loaded if ava
Erik Corry Chromium.org 2015/06/02 11:18:52 Done.
46 static void Initialize(ScriptMode mode, 46 static void Initialize(ScriptMode mode,
47 v8::ArrayBuffer::Allocator* allocator); 47 v8::ArrayBuffer::Allocator* allocator);
48 48
49 v8::Isolate* isolate() { return isolate_; } 49 v8::Isolate* isolate() { return isolate_; }
50 50
51 // The implementations of Object.observe() and Promise enqueue v8 Microtasks 51 // The implementations of Object.observe() and Promise enqueue v8 Microtasks
52 // that should be executed just before control is returned to the message 52 // that should be executed just before control is returned to the message
53 // loop. This method adds a MessageLoop TaskObserver which runs any pending 53 // loop. This method adds a MessageLoop TaskObserver which runs any pending
54 // Microtasks each time a Task is completed. This method should be called 54 // Microtasks each time a Task is completed. This method should be called
55 // once, when a MessageLoop is created and it should be called on the 55 // once, when a MessageLoop is created and it should be called on the
(...skipping 13 matching lines...) Expand all
69 scoped_ptr<RunMicrotasksObserver> task_observer_; 69 scoped_ptr<RunMicrotasksObserver> task_observer_;
70 scoped_ptr<V8IsolateMemoryDumpProvider> isolate_memory_dump_provider_; 70 scoped_ptr<V8IsolateMemoryDumpProvider> isolate_memory_dump_provider_;
71 AccessMode access_mode_; 71 AccessMode access_mode_;
72 72
73 DISALLOW_COPY_AND_ASSIGN(IsolateHolder); 73 DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
74 }; 74 };
75 75
76 } // namespace gin 76 } // namespace gin
77 77
78 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_ 78 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698