Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: test/win/win_child_process_test.cc

Issue 1164453003: Refactor multiprocess test code to allow multiple child processes to be launched. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@multiprocess_test
Patch Set: Tweaks. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/win/win_child_process_test.cc
diff --git a/test/win/win_multiprocess_test.cc b/test/win/win_child_process_test.cc
similarity index 63%
copy from test/win/win_multiprocess_test.cc
copy to test/win/win_child_process_test.cc
index 18b6ca427cc326ee5b10cd8fbb9f8d8556695351..7d27c7f4766e0bd86c184e703ebb1403f2ae3778 100644
--- a/test/win/win_multiprocess_test.cc
+++ b/test/win/win_child_process_test.cc
@@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "test/win/win_multiprocess.h"
+#include "test/win/win_child_process.h"
#include "base/basictypes.h"
#include "gtest/gtest.h"
@@ -21,24 +21,23 @@ namespace crashpad {
namespace test {
namespace {
-class TestWinMultiprocess final : public WinMultiprocess {
+class TestWinChildProcess final : public WinChildProcess {
public:
- TestWinMultiprocess() : WinMultiprocess() {}
+ TestWinChildProcess() : WinChildProcess() {}
- ~TestWinMultiprocess() {}
+ ~TestWinChildProcess() {}
private:
- // WinMultiprocess will have already exercised the pipes.
- void WinMultiprocessParent() override {}
+ // WinChildProcess will have already exercised the pipes.
+ void Run() override {}
- void WinMultiprocessChild() override {}
-
- DISALLOW_COPY_AND_ASSIGN(TestWinMultiprocess);
+ DISALLOW_COPY_AND_ASSIGN(TestWinChildProcess);
};
-TEST(WinMultiprocess, WinMultiprocess) {
- TestWinMultiprocess win_multiprocess;
- win_multiprocess.Run();
+TEST(WinChildProcessTest, WinChildProcess) {
+ WinChildProcess::EntryPoint<TestWinChildProcess>();
+
+ WinChildProcess::Launch();
}
scottmg 2015/06/01 21:53:22 Could you add a test that launches multiple child
erikwright (departed) 2015/06/24 20:01:35 Done.
} // namespace

Powered by Google App Engine
This is Rietveld 408576698