snapshot/win/process_reader_win_test.cc - Issue 1164453003: Refactor multiprocess test code to allow multiple child processes to be launched.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/win/process_reader_win_test.cc

Issue 1164453003: Refactor multiprocess test code to allow multiple child processes to be launched. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@multiprocess_test

Patch Set: Review comment. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: snapshot/win/process_reader_win_test.cc

diff --git a/snapshot/win/process_reader_win_test.cc b/snapshot/win/process_reader_win_test.cc

index d4890b8a0f33369c6983992597ff18c845dd6ee5..6cd06e5bdb8c3cf3fcec79c86c6d68e62bff8af5 100644

--- a/snapshot/win/process_reader_win_test.cc

+++ b/snapshot/win/process_reader_win_test.cc

@@ -85,8 +85,7 @@ class ProcessReaderChild final : public WinMultiprocess {

};

TEST(ProcessReaderWin, ChildBasic) {

- ProcessReaderChild process_reader_child;

- process_reader_child.Run();

+ WinMultiprocess::Run<ProcessReaderChild>();

}

TEST(ProcessReaderWin, SelfOneThread) {

« no previous file with comments | « snapshot/win/pe_image_annotations_reader_test.cc ('k') | test/test.gyp » ('j') | no next file with comments »