Refactor multiprocess test code to allow multiple child processes to be launched.

test/win/win_multiprocess.h

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
 #ifndef CRASHPAD_TEST_WIN_WIN_MULTIPROCESS_H_
 #define CRASHPAD_TEST_WIN_WIN_MULTIPROCESS_H_
 
 #include <windows.h>
 
 #include "base/basictypes.h"
+#include "gtest/gtest.h"
+#include "test/win/win_child_process.h"
 #include "util/file/file_io.h"
 #include "util/win/scoped_handle.h"
 
 namespace crashpad {
 namespace test {
 
 //! \brief Manages a multiprocess test on Windows.
 class WinMultiprocess {
  public:
   WinMultiprocess();
 
   //! \brief Runs the test.
   //!
   //! This method establishes the testing environment by respawning the process
   //! as a child with additional flags.
   //!
   //! In the parent process, WinMultiprocessParent() is run, and in the child
   //! WinMultiprocessChild().
-  void Run();
+  template <class T>
+  static void Run() {
+    ASSERT_NO_FATAL_FAILURE(
+        WinChildProcess::EntryPoint<ChildProcessHelper<T>>());
+    // If WinChildProcess::EntryPoint returns, we are in the parent process.
+    scoped_ptr<WinChildProcess::Handles> child_handles = WinChildProcess::Launch();

[scottmg, 2015/06/01 21:53:22]

80 col

[erikwright (departed), 2015/06/24 20:01:35]

Done.

+    ASSERT_TRUE(child_handles.get());
+    T parent_process;
+    parent_process.child_handles_ = child_handles.get();
+    static_cast<WinMultiprocess*>(&parent_process)->WinMultiprocessParent();
+  }
 
  protected:
   virtual ~WinMultiprocess();
 
   //! \brief Returns the read pipe's file handle.
   //!
   //! This method may be called by either the parent or the child process.
   //! Anything written to the write pipe in the partner process will appear
   //! on this file handle in this process.
   //!
@@ skipping 25 matching lines @@
   //! attempt to read from the read pipe in the partner process will indicate
   //! end-of-file. WritePipeHandle() must not be called after this.
   void CloseWritePipe();
 
   //! \brief Returns a handle to the child process.
   //!
   //! This method may only be called by the parent process.
   HANDLE ChildProcess() const;
 
  private:
+  // Implements an adapter to provide WinMultiprocess with access to the
+  // anonymous pipe handles from WinChildProcess.
+  class ChildProcessHelperBase : public WinChildProcess {
+   public:
+    ChildProcessHelperBase() {}
+    ~ChildProcessHelperBase() override {}
+
+    void CloseWritePipeForwarder() { CloseWritePipe(); }
+    void CloseReadPipeForwarder() { CloseReadPipe(); }
+    FileHandle ReadPipeHandleForwarder() const { return ReadPipeHandle(); }
+    FileHandle WritePipeHandleForwarder() const { return WritePipeHandle(); }
+
+   private:
+    DISALLOW_COPY_AND_ASSIGN(ChildProcessHelperBase);
+  };
+
+  // Forwards WinChildProcess::Run to T::WinMultiprocessChild.
+  template <class T>
+  class ChildProcessHelper : public ChildProcessHelperBase {
+   public:
+    ChildProcessHelper() {}
+    ~ChildProcessHelper() override {}
+
+   private:
+    void Run() override {
+      T child_process;
+      child_process.child_process_helper_ = this;
+      static_cast<WinMultiprocess*>(&child_process)->WinMultiprocessChild();
+      exit(0);
+    }
+
+    DISALLOW_COPY_AND_ASSIGN(ChildProcessHelper);
+  };
+
   //! \brief The subclass-provided parent routine.
   //!
   //! Test failures should be reported via gtest: `EXPECT_*()`, `ASSERT_*()`,
   //! `FAIL()`, etc.
   //!
   //! This method must not use `WaitForSingleObject()`-family call to wait for
   //! the child process to exit, as this is handled by this class.
   //!
   //! Subclasses must implement this method to define how the parent operates.
-  virtual void WinMultiprocessParent() = 0;
+  virtual void

[scottmg, 2015/06/01 21:53:22]

extra \n

[erikwright (departed), 2015/06/24 20:01:35]

Done.

+  WinMultiprocessParent() = 0;
 
   //! \brief The subclass-provided child routine.
   //!
   //! Test failures should be reported via gtest: `EXPECT_*()`, `ASSERT_*()`,
   //! `FAIL()`, etc.
   //!
   //! Subclasses must implement this method to define how the child operates.
   //! Subclasses may exit with a failure status by using `LOG(FATAL)`,
   //! `abort()`, or similar. They may exit cleanly by returning from this
   //! method.
   virtual void WinMultiprocessChild() = 0;
 
-  ScopedFileHANDLE pipe_c2p_read_;
-  ScopedFileHANDLE pipe_c2p_write_;
-  ScopedFileHANDLE pipe_p2c_read_;
-  ScopedFileHANDLE pipe_p2c_write_;
-  ScopedKernelHANDLE child_handle_;
+  WinChildProcess::Handles* child_handles_;
+  ChildProcessHelperBase* child_process_helper_;
 
   DISALLOW_COPY_AND_ASSIGN(WinMultiprocess);
 };
 
 }  // namespace test
 }  // namespace crashpad
 
 #endif  // CRASHPAD_TEST_WIN_WIN_MULTIPROCESS_H_