Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: PRESUBMIT_test.py

Issue 116443011: Do per-file OWNERS check for per-file DEPS changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT_test.py
diff --git a/PRESUBMIT_test.py b/PRESUBMIT_test.py
index 1c7990ce898bb824b1b7068d7787826b9250a0d1..509c45c891b95ebeb138e9901043eb7008da69b7 100755
--- a/PRESUBMIT_test.py
+++ b/PRESUBMIT_test.py
@@ -394,7 +394,7 @@ class InvalidOSMacroNamesTest(unittest.TestCase):
class CheckAddedDepsHaveTetsApprovalsTest(unittest.TestCase):
- def testDepsFilesToCheck(self):
+ def testFilesToCheckForIncomingDeps(self):
changed_lines = [
'"+breakpad",',
'"+chrome/installer",',
@@ -404,6 +404,7 @@ class CheckAddedDepsHaveTetsApprovalsTest(unittest.TestCase):
'"+components/breakpad",',
'"+components/nacl/common",',
'"+content/public/browser/render_process_host.h",',
+ '"+jni/fooblat.h",',
'"+grit", # For generated headers',
'"+grit/generated_resources.h",',
'"+grit/",',
@@ -412,20 +413,20 @@ class CheckAddedDepsHaveTetsApprovalsTest(unittest.TestCase):
'"+tools/memory_watcher",',
'"+third_party/lss/linux_syscall_support.h",',
]
- files_to_check = PRESUBMIT._DepsFilesToCheck(re, changed_lines)
+ files_to_check = PRESUBMIT._FilesToCheckForIncomingDeps(re, changed_lines)
expected = set([
'breakpad/DEPS',
'chrome/installer/DEPS',
- 'chrome/plugin/DEPS',
- 'chrome/utility/DEPS',
- 'chromeos/DEPS',
+ 'chrome/plugin/chrome_content_plugin_client.h',
+ 'chrome/utility/chrome_content_utility_client.h',
+ 'chromeos/chromeos_paths.h',
'components/breakpad/DEPS',
'components/nacl/common/DEPS',
- 'content/public/browser/DEPS',
+ 'content/public/browser/render_process_host.h',
'policy/DEPS',
'sandbox/DEPS',
'tools/memory_watcher/DEPS',
- 'third_party/lss/DEPS',
+ 'third_party/lss/linux_syscall_support.h',
])
self.assertEqual(expected, files_to_check);
« no previous file with comments | « PRESUBMIT.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698