Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Issue 116443008: Add mac_write_linker_maps gyp define. (Closed)

Created:
6 years, 12 months ago by Nico
Modified:
6 years, 12 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Add mac_write_linker_maps gyp define. With GYP_DEFINES=mac_write_linker_maps=1, ld64 will be instructed to write .map files, which can then be visualized to get an idea of binary size. (Works best in a static library build.) BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242693

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M build/common.gypi View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
6 years, 12 months ago (2013-12-28 00:31:33 UTC) #1
Mark Mentovai
LGTM
6 years, 12 months ago (2013-12-28 01:59:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/116443008/1
6 years, 12 months ago (2013-12-28 02:02:59 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=240411
6 years, 12 months ago (2013-12-28 03:29:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/116443008/1
6 years, 12 months ago (2013-12-28 19:04:56 UTC) #5
commit-bot: I haz the power
6 years, 12 months ago (2013-12-28 21:27:45 UTC) #6
Message was sent while issue was closed.
Change committed as 242693

Powered by Google App Engine
This is Rietveld 408576698