sdk/lib/_internal/compiler/implementation/universe/universe.dart - Issue 116443002: Revert "Implement tracing for function expressions and statements, and infer types of parameters of…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/universe/universe.dart

Issue 116443002: Revert "Implement tracing for function expressions and statements, and infer types of parameters of… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/inferrer/type_graph_nodes.dart ('k') | tests/compiler/dart2js/closure_tracer_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/universe/universe.dart

diff --git a/sdk/lib/_internal/compiler/implementation/universe/universe.dart b/sdk/lib/_internal/compiler/implementation/universe/universe.dart

index 36181ceba0754d75e446677d2df266f140683755..eed40c8ae5fc337ccc5ebee367e54c74aa2f62e0 100644

--- a/sdk/lib/_internal/compiler/implementation/universe/universe.dart

+++ b/sdk/lib/_internal/compiler/implementation/universe/universe.dart

@@ -334,10 +334,8 @@ class Selector {

}

if (isGetter()) return true;

if (isSetter()) return false;

- return signatureApplies(element, compiler);

- }

- bool signatureApplies(FunctionElement function, Compiler compiler) {

+ FunctionElement function = element;

FunctionSignature parameters = function.computeSignature(compiler);

if (argumentCount > parameters.parameterCount) return false;

int requiredParameterCount = parameters.requiredParameterCount;