Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(20)

Issue 1164423007: Make inspector-protocol/debugger/debugger-step-into-dedicated-worker.html not timeout (Closed)

Created:
4 years, 10 months ago by yurys
Modified:
4 years, 10 months ago
Reviewers:
kozy, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make inspector-protocol/debugger/debugger-step-into-dedicated-worker.html not timeout The test was timing out because sometimes Debugger.enable and Runtime.run command were dispatched before worker context initialization completed. Runtime.run was executed before WorkerInspectorController::pauseOnStart was called from WorkerThread and we kept waiting forever for Runtime.run which has already been dispatched. BUG=496805 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.h View 4 chunks +4 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yurys
4 years, 10 months ago (2015-06-09 15:32:18 UTC) #2
yurys
4 years, 10 months ago (2015-06-09 15:34:59 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164423007/1
4 years, 10 months ago (2015-06-09 15:35:00 UTC) #6
pfeldman
lgtm
4 years, 10 months ago (2015-06-09 15:45:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164423007/1
4 years, 10 months ago (2015-06-09 15:46:00 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-09 17:32:38 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196786

Powered by Google App Engine
This is Rietveld 408576698