Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(70)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1164413003: Fix unit test style in core/{animation,css,fetch,frame,layout,style,timing}/. (Closed)

Created:
4 years, 10 months ago by tkent
Modified:
4 years, 10 months ago
Reviewers:
kochi
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, rwlbuis, Yoav Weiss, blink-reviews-css, szager+layoutwatch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, Eric Willigers, kenneth.christiansen, rjwright, blink-reviews-style_chromium.org, zoltan1, darktears, Nate Chapin, tyoshino+watch_chromium.org, blink-reviews-rendering, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix unit test style in core/{animation,css,fetch,frame,layout,style,timing}/. BUG=498604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196894

Patch Set 1 #

Total comments: 8

Patch Set 2 : anonymous #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -161 lines) Patch
M Source/core/animation/AnimationClockTest.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/animation/AnimationEffectTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/animation/AnimationTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/animation/AnimationTranslationUtilTest.cpp View 3 chunks +2 lines, -6 lines 0 comments Download
M Source/core/animation/EffectInputTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/animation/KeyframeEffectModelTest.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/animation/TimingCalculationsTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableColorTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDoubleAndBoolTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableDoubleTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableLengthTest.cpp View 1 1 chunk +5 lines, -7 lines 0 comments Download
M Source/core/animation/animatable/AnimatableNeutralTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/animation/animatable/AnimatableStrokeDasharrayListTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableUnknownTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/css/AffectedByFocusTest.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M Source/core/css/CSSCalculationValueTest.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/css/DragUpdateTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/MediaQueryListTest.cpp View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/css/invalidation/DescendantInvalidationSetTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSParserValuesTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/fetch/CachingCorrectnessTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/fetch/ImageResourceTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/fetch/RawResourceTest.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceTest.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/frame/OriginsUsingFeaturesTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTableRowTest.cpp View 1 2 chunks +1 line, -5 lines 0 comments Download
M Source/core/layout/LayoutThemeTest.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M Source/core/layout/OverflowModelTest.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/core/layout/shapes/BoxShapeTest.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/core/style/ComputedStyleTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/style/OutlineValueTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/style/SVGComputedStyleTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/core/timing/MemoryInfoTest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
tkent
kochi-san, would you review this please?
4 years, 10 months ago (2015-06-10 07:46:08 UTC) #2
kochi
lgtm with nits. https://codereview.chromium.org/1164413003/diff/1/Source/core/animation/animatable/AnimatableLengthTest.cpp File Source/core/animation/animatable/AnimatableLengthTest.cpp (right): https://codereview.chromium.org/1164413003/diff/1/Source/core/animation/animatable/AnimatableLengthTest.cpp#newcode20 Source/core/animation/animatable/AnimatableLengthTest.cpp:20: } // namespace nit: "anonymous namespace"? ...
4 years, 10 months ago (2015-06-10 08:04:09 UTC) #3
tkent
https://codereview.chromium.org/1164413003/diff/1/Source/core/animation/animatable/AnimatableLengthTest.cpp File Source/core/animation/animatable/AnimatableLengthTest.cpp (right): https://codereview.chromium.org/1164413003/diff/1/Source/core/animation/animatable/AnimatableLengthTest.cpp#newcode20 Source/core/animation/animatable/AnimatableLengthTest.cpp:20: } // namespace On 2015/06/10 08:04:08, Takayoshi Kochi wrote: ...
4 years, 10 months ago (2015-06-10 08:31:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164413003/20001
4 years, 10 months ago (2015-06-10 08:32:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66007)
4 years, 10 months ago (2015-06-10 11:07:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164413003/20001
4 years, 10 months ago (2015-06-10 14:05:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/66052)
4 years, 10 months ago (2015-06-10 17:07:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164413003/20001
4 years, 10 months ago (2015-06-10 19:09:28 UTC) #15
commit-bot: I haz the power
4 years, 10 months ago (2015-06-10 19:58:29 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196894

Powered by Google App Engine
This is Rietveld 408576698