Use C++ style type casts.

src/objects.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 6736 matching lines @@
 // *AsciiStringReadBlock routines.
 const unibrow::byte* ConsString::ConsStringReadBlock(ReadBlockBuffer* rbb,
                                                      unsigned* offset_ptr,
                                                      unsigned max_chars) {
   ConsString* current = this;
   unsigned offset = *offset_ptr;
   int offset_correction = 0;
 
   while (true) {
     String* left = current->first();
-    unsigned left_length = (unsigned)left->length();
+    unsigned left_length = static_cast<unsigned>(left->length());
     if (left_length > offset &&
         (max_chars <= left_length - offset ||
          (rbb->capacity <= left_length - offset &&
           (max_chars = left_length - offset, true)))) {  // comma operator!
       // Left hand side only - iterate unless we have reached the bottom of
       // the cons tree.  The assignment on the left of the comma operator is
       // in order to make use of the fact that the -IntoBuffer routines can
       // produce at most 'capacity' characters.  This enables us to postpone
       // the point where we switch to the -IntoBuffer routines (below) in order
       // to maximize the chances of delegating a big chunk of work to the
@@ skipping 354 matching lines @@
       *blew_stack = true;
       return NULL;
     }
     // Go right.
     ConsString* cons_string = frames_[OffsetForDepth(depth_ - 1)];
     String* string = cons_string->second();
     int32_t type = string->map()->instance_type();
     if ((type & kStringRepresentationMask) != kConsStringTag) {
       // Pop stack so next iteration is in correct place.
       Pop();
-      unsigned length = (unsigned) string->length();
+      unsigned length = static_cast<unsigned>(string->length());
       // Could be a flattened ConsString.
       if (length == 0) continue;
       *length_out = length;
       *type_out = type;
       consumed_ += length;
       return string;
     }
     cons_string = ConsString::cast(string);
     // TODO(dcarney) Add back root optimization.
     PushRight(cons_string);
     // Need to traverse all the way left.
     while (true) {
       // Continue left.
       string = cons_string->first();
       type = string->map()->instance_type();
       if ((type & kStringRepresentationMask) != kConsStringTag) {
         AdjustMaximumDepth();
-        unsigned length = (unsigned) string->length();
+        unsigned length = static_cast<unsigned>(string->length());
         ASSERT(length != 0);
         *length_out = length;
         *type_out = type;
         consumed_ += length;
         return string;
       }
       cons_string = ConsString::cast(string);
       PushLeft(cons_string);
     }
   }
   UNREACHABLE();
   return NULL;
 }
 
 
 // This method determines the type of string involved and then copies
 // a whole chunk of characters into a buffer.  It can be used with strings
 // that have been glued together to form a ConsString and which must cooperate
 // to fill up a buffer.
 void String::ReadBlockIntoBuffer(String* input,
                                  ReadBlockBuffer* rbb,
                                  unsigned* offset_ptr,
                                  unsigned max_chars) {
-  ASSERT(*offset_ptr <= (unsigned)input->length());
+  ASSERT(*offset_ptr <= static_cast<unsigned>(input->length()));
   if (max_chars == 0) return;
 
   switch (StringShape(input).representation_tag()) {
     case kSeqStringTag:
       if (input->IsOneByteRepresentation()) {
         SeqOneByteString::cast(input)->SeqOneByteStringReadBlockIntoBuffer(rbb,
                                                                  offset_ptr,
                                                                  max_chars);
         return;
       } else {
@@ skipping 30 matching lines @@
   UNREACHABLE();
   return;
 }
 
 
 const unibrow::byte* String::ReadBlock(String* input,
                                        unibrow::byte* util_buffer,
                                        unsigned capacity,
                                        unsigned* remaining,
                                        unsigned* offset_ptr) {
-  ASSERT(*offset_ptr <= (unsigned)input->length());
+  ASSERT(*offset_ptr <= static_cast<unsigned>(input->length()));
   unsigned chars = input->length() - *offset_ptr;
   ReadBlockBuffer rbb(util_buffer, 0, capacity, 0);
   const unibrow::byte* answer = ReadBlock(input, &rbb, offset_ptr, chars);
   ASSERT(rbb.remaining <= static_cast<unsigned>(input->length()));
   *remaining = rbb.remaining;
   return answer;
 }
 
 
 const unibrow::byte* String::ReadBlock(String** raw_input,
                                        unibrow::byte* util_buffer,
                                        unsigned capacity,
                                        unsigned* remaining,
                                        unsigned* offset_ptr) {
   Handle<String> input(raw_input);
-  ASSERT(*offset_ptr <= (unsigned)input->length());
+  ASSERT(*offset_ptr <= static_cast<unsigned>(input->length()));
   unsigned chars = input->length() - *offset_ptr;
   if (chars > capacity) chars = capacity;
   ReadBlockBuffer rbb(util_buffer, 0, capacity, 0);
   ReadBlockIntoBuffer(*input, &rbb, offset_ptr, chars);
   ASSERT(rbb.remaining <= static_cast<unsigned>(input->length()));
   *remaining = rbb.remaining;
   return rbb.util_buffer;
 }
 
 
 // This will iterate unless the block of string data spans two 'halves' of
 // a ConsString, in which case it will recurse.  Since the block of string
 // data to be read has a maximum size this limits the maximum recursion
 // depth to something sane.  Since C++ does not have tail call recursion
 // elimination, the iteration must be explicit.
 void ConsString::ConsStringReadBlockIntoBuffer(ReadBlockBuffer* rbb,
                                                unsigned* offset_ptr,
                                                unsigned max_chars) {
   ConsString* current = this;
   unsigned offset = *offset_ptr;
   int offset_correction = 0;
 
   while (true) {
     String* left = current->first();
-    unsigned left_length = (unsigned)left->length();
+    unsigned left_length = static_cast<unsigned>(left->length());
     if (left_length > offset &&
       max_chars <= left_length - offset) {
       // Left hand side only - iterate unless we have reached the bottom of
       // the cons tree.
       if (StringShape(left).IsCons()) {
         current = ConsString::cast(left);
         continue;
       } else {
         String::ReadBlockIntoBuffer(left, rbb, &offset, max_chars);
         *offset_ptr = offset + offset_correction;
@@ skipping 6865 matching lines @@
   set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
   set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
   set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
   set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
   set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
   set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
   set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
 }
 
 } }  // namespace v8::internal