SPDY - implement greedy approach to read all the data and process it

net/spdy/spdy_session_test_util.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_SPDY_SPDY_SESSION_TEST_UTIL_H_
+#define NET_SPDY_SPDY_SESSION_TEST_UTIL_H_
+
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/message_loop.h"
+#include "base/pending_task.h"
+
+namespace net {
+
+class SpdySessionTestTaskObserver : public MessageLoop::TaskObserver {

[Ryan Sleevi, 2013/02/06 23:04:46]

Please provide comments about what this class does.

[ramant (doing other things), 2013/02/07 02:11:07]

Done.

+ public:
+  SpdySessionTestTaskObserver(const std::string& file_name,

[Ryan Sleevi, 2013/02/06 23:04:46]

Please provide comments on what these parameters are for.

[ramant (doing other things), 2013/02/07 02:11:07]

Done.

+                              const std::string& function_name);
+
+  virtual ~SpdySessionTestTaskObserver();
+
+  virtual void WillProcessTask(const base::PendingTask& pending_task) OVERRIDE;
+
+  virtual void DidProcessTask(const base::PendingTask& pending_task) OVERRIDE;

[Ryan Sleevi, 2013/02/06 23:04:46]

style: Within net/ (and in general, within Chrome code), the style has largely
been:

1) No whitespace between the overrides
2) A comment that explains which interface is being implemented (eg: //
MessageLoop::TaskObserver implementation)

This is because the style guide required this up until pkasting's grand style
purge in Sept (
https://sites.google.com/a/chromium.org/dev/system/app/pages/admin/compare?wu...
).  

[ramant (doing other things), 2013/02/07 02:11:07]

Done.

+
+  uint32 posted_count() const { return posted_count_; }

[Ryan Sleevi, 2013/02/06 23:04:46]

Please provide comments explaining what this number signifies.

[ramant (doing other things), 2013/02/07 02:11:07]

Done.

+
+ private:
+  uint32 posted_count_;
+  std::string file_name_;
+  std::string function_name_;
+};
+
+}  // namespace net
+
+#endif  // NET_SPDY_SPDY_SESSION_TEST_UTIL_H_