Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: runtime/vm/debugger.cc

Issue 11644085: Ignore nested breakpoints (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/debugger.cc
===================================================================
--- runtime/vm/debugger.cc (revision 16456)
+++ runtime/vm/debugger.cc (working copy)
@@ -852,7 +852,12 @@
void Debugger::SignalExceptionThrown(const Object& exc) {
+ // We ignore this exception event when the VM is executing code invoked
+ // by the debugger to evaluate variables values, when we see a nested
+ // breakpoint or exception event, or if the debugger is not
+ // interested in exception events.
if (ignore_breakpoints_ ||
+ (stack_trace_ != NULL) ||
(event_handler_ == NULL) ||
(exc_pause_info_ == kNoPauseOnExceptions)) {
return;
@@ -1332,7 +1337,10 @@
void Debugger::SignalBpReached() {
- if (ignore_breakpoints_) {
+ // We ignore this breakpoint when the VM is executing code invoked
+ // by the debugger to evaluate variables values, or when we see a nested
+ // breakpoint or exception event.
+ if (ignore_breakpoints_ || (stack_trace_ != NULL)) {
return;
}
DebuggerStackTrace* stack_trace = CollectStackTrace();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698