Put extension enable logic into a ExtensionEnableFlow.

chrome/browser/ui/webui/ntp/app_launcher_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/ntp/app_launcher_handler.h"
 
-#include <string>
 #include <vector>
 
 #include "base/auto_reset.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/i18n/rtl.h"
 #include "base/metrics/field_trial.h"
 #include "base/metrics/histogram.h"
 #include "base/utf_string_conversions.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/app_notification.h"
 #include "chrome/browser/extensions/app_notification_manager.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_prefs.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_sorting.h"
 #include "chrome/browser/extensions/extension_system.h"
 #include "chrome/browser/extensions/management_policy.h"
 #include "chrome/browser/favicon/favicon_service_factory.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/browser_tabstrip.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/extensions/application_launch.h"
+#include "chrome/browser/ui/extensions/extension_enable_flow.h"
 #include "chrome/browser/ui/webui/extensions/extension_icon_source.h"
 #include "chrome/browser/ui/webui/ntp/new_tab_ui.h"
 #include "chrome/browser/ui/webui/web_ui_util.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "chrome/common/extensions/extension_resource.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
@@ skipping 773 matching lines @@
 
   GURL url(net::UnescapeURLComponent(escaped_url, kUnescapeRules));
   DCHECK(profile->GetExtensionService());
   if (!profile->GetExtensionService()->IsInstalledApp(url))
     return;
 
   RecordAppLaunchType(bucket);
 }
 
 void AppLauncherHandler::PromptToEnableApp(const std::string& extension_id) {
-  const Extension* extension =
-      extension_service_->GetExtensionById(extension_id, true);
-  if (!extension) {
-    extension = extension_service_->GetTerminatedExtension(extension_id);
-    // It's possible (though unlikely) the app could have been uninstalled since
-    // the user clicked on it.
-    if (!extension)
-      return;
-    // If the app was terminated, reload it first. (This reallocates the
-    // Extension object.)
-    extension_service_->ReloadExtension(extension_id);
-    extension = extension_service_->GetExtensionById(extension_id, true);
-  }
-
-  ExtensionPrefs* extension_prefs = extension_service_->extension_prefs();
-  if (!extension_prefs->DidExtensionEscalatePermissions(extension_id)) {
-    // Enable the extension immediately if its privileges weren't escalated.
-    // This is a no-op if the extension was previously terminated.
-    extension_service_->EnableExtension(extension_id);
-
-    // Launch app asynchronously so the image will update.
-    StringValue app_id(extension_id);
-    web_ui()->CallJavascriptFunction("ntp.launchAppAfterEnable", app_id);
-    return;
-  }
-
   if (!extension_id_prompting_.empty())
     return;  // Only one prompt at a time.
 
   extension_id_prompting_ = extension_id;

[Evan Stade, 2012/12/21 22:45:26]

can you get rid of extension_id_prompting_ and just use
extension_enable_flow_->extension_id() as the single source of truth?

[xiyuan, 2012/12/22 00:35:43]

extension_id_prompting_ used to guard both uninstall UI and enable UI.
extension_enable_flow_ is only used for enable UI. If we want to keep existing
behavior, i.e. only one uninstall UI or enable UI is shown to the user, then we
need to test extension_enable_flow_ in uninstall UI code. 

I would say, the code is cleaner with current extension_id_prompting_ test. What
do you think?

[Evan Stade, 2013/01/02 21:55:38]

that's a reasonable explanation. Can you add "(either enable or uninstall)" to
the comment about extension_id_prompting_ in the header file?

[xiyuan, 2013/01/07 18:13:12]

Done.

-  GetExtensionInstallPrompt()->ConfirmReEnable(this, extension);
+  extension_enable_flow_.reset(new ExtensionEnableFlow(
+      Profile::FromWebUI(web_ui()), extension_id, this));
+  extension_enable_flow_->Start();
 }
 
 void AppLauncherHandler::ExtensionUninstallAccepted() {
   // Do the uninstall work here.
   DCHECK(!extension_id_prompting_.empty());
 
   // The extension can be uninstalled in another window while the UI was
   // showing. Do nothing in that case.
   const Extension* extension =
       extension_service_->GetExtensionById(extension_id_prompting_, true);
   if (!extension)
     return;
 
   extension_service_->UninstallExtension(extension_id_prompting_,
                                          false /* external_uninstall */, NULL);
   CleanupAfterUninstall();
 }
 
 void AppLauncherHandler::ExtensionUninstallCanceled() {
   CleanupAfterUninstall();
 }
 
-void AppLauncherHandler::InstallUIProceed() {
-  // Do the re-enable work here.
-  DCHECK(!extension_id_prompting_.empty());
+ExtensionInstallPrompt* AppLauncherHandler::CreateExtensionInstallPrompt() {
+  return new ExtensionInstallPrompt(web_ui()->GetWebContents());
+}
 
-  // The extension can be uninstalled in another window while the UI was
-  // showing. Do nothing in that case.
-  const Extension* extension =
-      extension_service_->GetExtensionById(extension_id_prompting_, true);
-  if (!extension)
-    return;
-
-  extension_service_->GrantPermissionsAndEnableExtension(
-      extension, extension_install_ui_->record_oauth2_grant());
+void AppLauncherHandler::ExtensionEnableFlowFinished(
+    ExtensionEnableFlow* flow) {
+  DCHECK_EQ(extension_enable_flow_.get(), flow);
+  DCHECK_EQ(extension_id_prompting_, flow->extension_id());
 
   // We bounce this off the NTP so the browser can update the apps icon.
   // If we don't launch the app asynchronously, then the app's disabled
   // icon disappears but isn't replaced by the enabled icon, making a poor
   // visual experience.
-  StringValue app_id(extension->id());
+  StringValue app_id(flow->extension_id());
   web_ui()->CallJavascriptFunction("ntp.launchAppAfterEnable", app_id);
 
+  extension_enable_flow_.reset();
   extension_id_prompting_ = "";
 }
 
-void AppLauncherHandler::InstallUIAbort(bool user_initiated) {
+void AppLauncherHandler::ExtensionEnableFlowAborted(ExtensionEnableFlow* flow,
+                                                    bool user_initiated) {
+  DCHECK_EQ(extension_enable_flow_.get(), flow);
+  DCHECK_EQ(extension_id_prompting_, flow->extension_id());
+
   // We record the histograms here because ExtensionUninstallCanceled is also
   // called when the extension uninstall dialog is canceled.
   const Extension* extension =
       extension_service_->GetExtensionById(extension_id_prompting_, true);
   std::string histogram_name = user_initiated ?
       "Extensions.Permissions_ReEnableCancel" :
       "Extensions.Permissions_ReEnableAbort";
   ExtensionService::RecordPermissionMessagesHistogram(
       extension, histogram_name.c_str());
 
+  extension_enable_flow_.reset();
   CleanupAfterUninstall();
 }
 
 ExtensionUninstallDialog* AppLauncherHandler::GetExtensionUninstallDialog() {
   if (!extension_uninstall_dialog_.get()) {
     Browser* browser = chrome::FindBrowserWithWebContents(
         web_ui()->GetWebContents());
     extension_uninstall_dialog_.reset(
         ExtensionUninstallDialog::Create(browser, this));
   }
   return extension_uninstall_dialog_.get();
 }
-
-ExtensionInstallPrompt* AppLauncherHandler::GetExtensionInstallPrompt() {
-  if (!extension_install_ui_.get()) {
-    extension_install_ui_.reset(
-        new ExtensionInstallPrompt(web_ui()->GetWebContents()));
-  }
-  return extension_install_ui_.get();
-}