Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5374)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/cocoa/infobars/infobar_controller.mm

Issue 11644059: Change infobar creation to use a public static Create() method on the infobar delegate classes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/infobars/infobar_container_controller.h ('k') | chrome/browser/ui/cocoa/keystone_infobar_delegate.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/infobars/infobar_controller.mm
===================================================================
--- chrome/browser/ui/cocoa/infobars/infobar_controller.mm (revision 175396)
+++ chrome/browser/ui/cocoa/infobars/infobar_controller.mm (working copy)
@@ -248,10 +248,8 @@
if (!infoBarClosing_)
return;
- // Notify the delegate that the infobar was closed. The delegate will delete
- // itself as a result of InfoBarClosed(), so we null out its pointer.
if (delegate_) {
- delegate_->InfoBarClosed();
+ delete delegate_;
delegate_ = NULL;
}
« no previous file with comments | « chrome/browser/ui/cocoa/infobars/infobar_container_controller.h ('k') | chrome/browser/ui/cocoa/keystone_infobar_delegate.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698