Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5279)

Unified Diff: chrome/browser/pepper_broker_infobar_delegate.h

Issue 11644059: Change infobar creation to use a public static Create() method on the infobar delegate classes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/pepper_broker_infobar_delegate.h
===================================================================
--- chrome/browser/pepper_broker_infobar_delegate.h (revision 175396)
+++ chrome/browser/pepper_broker_infobar_delegate.h (working copy)
@@ -22,14 +22,15 @@
// by storing a content setting for the site.
class PepperBrokerInfoBarDelegate : public ConfirmInfoBarDelegate {
public:
- virtual ~PepperBrokerInfoBarDelegate();
+ // Determines whether the broker setting is allow, deny, or ask. In the first
+ // two cases, runs the callback directly. In the third, creates a pepper
+ // broker delegate and adds it to the InfoBarService associated with
+ // |web_contents|.
+ static void Create(content::WebContents* web_contents,
+ const GURL& url,
+ const FilePath& plugin_path,
+ const base::Callback<void(bool)>& callback);
- static void Show(
- content::WebContents* web_contents,
- const GURL& url,
- const FilePath& plugin_path,
- const base::Callback<void(bool)>& callback);
-
// ConfirmInfoBarDelegate:
virtual string16 GetMessageText() const OVERRIDE;
virtual int GetButtons() const OVERRIDE;
@@ -48,6 +49,7 @@
const std::string& languages,
HostContentSettingsMap* content_settings,
const base::Callback<void(bool)>& callback);
+ virtual ~PepperBrokerInfoBarDelegate();
void DispatchCallback(bool result);
« no previous file with comments | « chrome/browser/password_manager/password_manager_delegate_impl.cc ('k') | chrome/browser/pepper_broker_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698