chrome/browser/infobars/infobar_extension_api.cc - Issue 11644059: Change infobar creation to use a public static Create() method on the infobar delegate classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/infobars/infobar_extension_api.cc

Issue 11644059: Change infobar creation to use a public static Create() method on the infobar delegate classes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/infobars/infobar_extension_api.cc

===================================================================

--- chrome/browser/infobars/infobar_extension_api.cc (revision 175396)

+++ chrome/browser/infobars/infobar_extension_api.cc (working copy)

@@ -64,11 +64,9 @@

return false;

}

- InfoBarService* infobar_service =

- InfoBarService::FromWebContents(web_contents);

- infobar_service->AddInfoBar(

- new ExtensionInfoBarDelegate(browser, infobar_service,

- GetExtension(), url, height));

+ ExtensionInfoBarDelegate::Create(

+ InfoBarService::FromWebContents(web_contents), browser, GetExtension(),

+ url, height);

// TODO(finnur): Return the actual DOMWindow object. Bug 26463.

DCHECK(browser->extension_window_controller());

« no previous file with comments | « chrome/browser/infobars/infobar.cc ('k') | chrome/browser/infobars/infobar_tab_helper.h » ('j') | no next file with comments »