Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/browser/extensions/extension_infobar_delegate.h

Issue 11644059: Change infobar creation to use a public static Create() method on the infobar delegate classes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_infobar_delegate.h
===================================================================
--- chrome/browser/extensions/extension_infobar_delegate.h (revision 175396)
+++ chrome/browser/extensions/extension_infobar_delegate.h (working copy)
@@ -33,12 +33,15 @@
virtual ~DelegateObserver() {}
};
- ExtensionInfoBarDelegate(Browser* browser,
- InfoBarService* infobar_service,
- const extensions::Extension* extension,
- const GURL& url,
- int height);
+ virtual ~ExtensionInfoBarDelegate();
+ // Creates an extension delegate and adds it to |infobar_service|.
+ static void Create(InfoBarService* infobar_service,
+ Browser* browser,
+ const extensions::Extension* extension,
+ const GURL& url,
+ int height);
+
const extensions::Extension* extension() { return extension_; }
extensions::ExtensionHost* extension_host() { return extension_host_.get(); }
int height() { return height_; }
@@ -48,7 +51,11 @@
bool closing() const { return closing_; }
private:
- virtual ~ExtensionInfoBarDelegate();
+ ExtensionInfoBarDelegate(Browser* browser,
+ InfoBarService* infobar_service,
+ const extensions::Extension* extension,
+ const GURL& url,
+ int height);
// InfoBarDelegate:
virtual InfoBar* CreateInfoBar(InfoBarService* owner) OVERRIDE;
« no previous file with comments | « chrome/browser/extensions/app_notify_channel_ui_impl.cc ('k') | chrome/browser/extensions/extension_infobar_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698