Change infobar creation to use a public static Create() method on the infobar delegate classes.

chrome/browser/ui/cocoa/keystone_infobar_delegate.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/keystone_infobar_delegate.h"
 
 #import <AppKit/AppKit.h>
 
 #include <string>
 
@@ skipping 20 matching lines @@
 #include "ui/base/resource/resource_bundle.h"
 
 class SkBitmap;
 
 namespace {
 
 // KeystonePromotionInfoBarDelegate -------------------------------------------
 
 class KeystonePromotionInfoBarDelegate : public ConfirmInfoBarDelegate {
  public:
+  // If there's an active tab, creates a keystone promotion delegate and adds it
+  // to the InfoBarService associated with that tab.
+  static void Create();
+
+ private:
   KeystonePromotionInfoBarDelegate(InfoBarService* infobar_service,
                                    PrefService* prefs);
-
- private:
   virtual ~KeystonePromotionInfoBarDelegate();
 
   // Sets this info bar to be able to expire.  Called a predetermined amount
   // of time after this object is created.
   void SetCanExpire() { can_expire_ = true; }
 
   // ConfirmInfoBarDelegate
   virtual gfx::Image* GetIcon() const OVERRIDE;
   virtual string16 GetMessageText() const OVERRIDE;
   virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
   virtual bool Accept() OVERRIDE;
   virtual bool Cancel() OVERRIDE;
   virtual bool ShouldExpireInternal(
       const content::LoadCommittedDetails& details) const OVERRIDE;
 
   // The prefs to use.
   PrefService* prefs_;  // weak
 
   // Whether the info bar should be dismissed on the next navigation.
   bool can_expire_;
 
   // Used to delay the expiration of the info bar.
   base::WeakPtrFactory<KeystonePromotionInfoBarDelegate> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(KeystonePromotionInfoBarDelegate);
 };
 
+// static
+void KeystonePromotionInfoBarDelegate::Create() {
+  Browser* browser = chrome::GetLastActiveBrowser();
+  if (browser) {
+    content::WebContents* webContents = chrome::GetActiveWebContents(browser);
+
+    if (webContents) {
+      InfoBarService* infobar_service =
+          InfoBarService::FromWebContents(webContents);
+      infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+          new KeystonePromotionInfoBarDelegate(
+              infobar_service,
+              Profile::FromBrowserContext(
+                  webContents->GetBrowserContext())->GetPrefs())));
+    }
+  }
+}
+
 KeystonePromotionInfoBarDelegate::KeystonePromotionInfoBarDelegate(
     InfoBarService* infobar_service,
     PrefService* prefs)
     : ConfirmInfoBarDelegate(infobar_service),
       prefs_(prefs),
       can_expire_(false),
       ALLOW_THIS_IN_INITIALIZER_LIST(weak_ptr_factory_(this)) {
   const base::TimeDelta kCanExpireOnNavigationAfterDelay =
       base::TimeDelta::FromSeconds(8);
   MessageLoop::current()->PostDelayedTask(FROM_HERE,
@@ skipping 100 matching lines @@
       [[dictionary objectForKey:kAutoupdateStatusStatus] intValue]);
 
   if (status == kAutoupdateNone || status == kAutoupdateRegistering) {
     return;
   }
 
   [self removeObserver];
 
   if (status != kAutoupdateRegisterFailed &&
       [[KeystoneGlue defaultKeystoneGlue] needsPromotion]) {
-    Browser* browser = chrome::GetLastActiveBrowser();
-    if (browser) {
-      content::WebContents* webContents = chrome::GetActiveWebContents(browser);
-
-      // Only show if no other info bars are showing, because that's how the
-      // default browser info bar works.
-      if (webContents) {
-        InfoBarService* infobarService =
-            InfoBarService::FromWebContents(webContents);
-        if (infobarService->GetInfoBarCount() == 0) {
-          infobarService->AddInfoBar(
-              new KeystonePromotionInfoBarDelegate(
-                  infobarService,
-                  Profile::FromBrowserContext(
-                      webContents->GetBrowserContext())->GetPrefs()));
-        }
-      }
-    }
+    KeystonePromotionInfoBarDelegate::Create();
   }
 
   [self release];
 }
 
 - (void)removeObserver {
   [[NSNotificationCenter defaultCenter] removeObserver:self];
 }
 
 @end  // @implementation KeystonePromotionInfoBar
 
 // static
 void KeystoneInfoBar::PromotionInfoBar(Profile* profile) {
   KeystonePromotionInfoBar* promotionInfoBar =
       [[[KeystonePromotionInfoBar alloc] init] autorelease];
 
   [promotionInfoBar checkAndShowInfoBarForProfile:profile];
 }