Change infobar creation to use a public static Create() method on the infobar delegate classes.

chrome/browser/translate/translate_infobar_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/translate/translate_infobar_delegate.h"
 
 #include <algorithm>
 
 #include "base/metrics/histogram.h"
 #include "chrome/browser/api/infobars/infobar_service.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/translate/translate_manager.h"
 #include "chrome/browser/translate/translate_tab_helper.h"
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/generated_resources.h"
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 using content::NavigationEntry;
 
 // static
 const size_t TranslateInfoBarDelegate::kNoIndex = static_cast<size_t>(-1);
 
-// static
-TranslateInfoBarDelegate* TranslateInfoBarDelegate::CreateDelegate(
-    Type infobar_type,
-    InfoBarService* infobar_service,
-    PrefService* prefs,
-    const std::string& original_language,
-    const std::string& target_language) {
-  DCHECK_NE(TRANSLATION_ERROR, infobar_type);
-  // These must be validated by our callers.
-  DCHECK(TranslateManager::IsSupportedLanguage(target_language));
-  // The original language can only be "unknown" for the "translating"
-  // infobar, which is the case when the user started a translation from the
-  // context menu.
-  DCHECK(TranslateManager::IsSupportedLanguage(original_language) ||
-         ((infobar_type == TRANSLATING) &&
-          (original_language == chrome::kUnknownLanguageCode)));
-  TranslateInfoBarDelegate* delegate =
-      new TranslateInfoBarDelegate(infobar_type,
-                                   TranslateErrors::NONE,
-                                   infobar_service,
-                                   prefs,
-                                   original_language,
-                                   target_language);
-  DCHECK_NE(kNoIndex, delegate->target_language_index());
-  return delegate;
-}
-
-TranslateInfoBarDelegate* TranslateInfoBarDelegate::CreateErrorDelegate(
-    TranslateErrors::Type error_type,
-    InfoBarService* infobar_service,
-    PrefService* prefs,
-    const std::string& original_language,
-    const std::string& target_language) {
-  return new TranslateInfoBarDelegate(TRANSLATION_ERROR,
-                                      error_type,
-                                      infobar_service,
-                                      prefs,
-                                      original_language,
-                                      target_language);
-}
-
 TranslateInfoBarDelegate::~TranslateInfoBarDelegate() {
 }
 
+// static
+void TranslateInfoBarDelegate::Create(InfoBarService* infobar_service,
+                                      bool replace_existing_infobar,
+                                      Type infobar_type,
+                                      TranslateErrors::Type error_type,
+                                      PrefService* prefs,
+                                      const std::string& original_language,
+                                      const std::string& target_language) {
+  // Check preconditions.
+  if (infobar_type != TRANSLATION_ERROR) {
+    DCHECK(TranslateManager::IsSupportedLanguage(target_language));
+    if (!TranslateManager::IsSupportedLanguage(original_language)) {
+      // The original language can only be "unknown" for the "translating"
+      // infobar, which is the case when the user started a translation from the
+      // context menu.
+      DCHECK_EQ(TRANSLATING, infobar_type);
+      DCHECK_EQ(chrome::kUnknownLanguageCode, original_language);
+    }
+  }
+
+  // Find any existing translate infobar delegate.
+  TranslateInfoBarDelegate* old_delegate = NULL;
+  for (size_t i = 0; i < infobar_service->GetInfoBarCount(); ++i) {
+    old_delegate =
+        infobar_service->GetInfoBarDelegateAt(i)->AsTranslateInfoBarDelegate();
+    if (old_delegate)
+      break;
+  }
+
+  // Create the new delegate.
+  scoped_ptr<TranslateInfoBarDelegate> infobar(
+      new TranslateInfoBarDelegate(infobar_type, error_type, infobar_service,
+                                   prefs, original_language, target_language));
+  infobar->UpdateBackgroundAnimation(old_delegate);
+
+  // Add the new delegate if necessary.
+  if (!old_delegate) {
+    infobar_service->AddInfoBar(infobar.PassAs<InfoBarDelegate>());
+  } else if (replace_existing_infobar) {
+    infobar_service->ReplaceInfoBar(old_delegate,
+                                    infobar.PassAs<InfoBarDelegate>());
+  }
+}
+
 void TranslateInfoBarDelegate::Translate() {
   if (!owner()->GetWebContents()->GetBrowserContext()->IsOffTheRecord()) {
     prefs_.ResetTranslationDeniedCount(original_language_code());
     prefs_.IncrementTranslationAcceptedCount(original_language_code());
   }
 
   TranslateManager::GetInstance()->TranslatePage(owner()->GetWebContents(),
                                                  original_language_code(),
                                                  target_language_code());
 
@@ skipping 275 matching lines @@
 TranslateInfoBarDelegate*
     TranslateInfoBarDelegate::AsTranslateInfoBarDelegate() {
   return this;
 }
 
 std::string TranslateInfoBarDelegate::GetPageHost() {
   NavigationEntry* entry =
       owner()->GetWebContents()->GetController().GetActiveEntry();
   return entry ? entry->GetURL().HostNoBrackets() : std::string();
 }