Change infobar creation to use a public static Create() method on the infobar delegate classes.

chrome/browser/plugins/plugin_infobar_delegates.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/plugins/plugin_infobar_delegates.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/api/infobars/infobar_service.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/google/google_util.h"
@@ skipping 10 matching lines @@
 #include "grit/theme_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/resource/resource_bundle.h"
 
 #if defined(OS_WIN)
 #include <shellapi.h>
 #include "ui/base/win/shell.h"
 #endif
 
 #if defined(ENABLE_PLUGIN_INSTALLATION)
+#if defined(OS_WIN)
+#include "base/win/metro.h"
+#endif
 #include "chrome/browser/plugins/plugin_installer.h"
 #endif  // defined(ENABLE_PLUGIN_INSTALLATION)
 
 using content::OpenURLParams;
 using content::Referrer;
 using content::UserMetricsAction;
 
 PluginInfoBarDelegate::PluginInfoBarDelegate(InfoBarService* infobar_service,
                                              const string16& name,
                                              const std::string& identifier)
@@ skipping 27 matching lines @@
   return &ResourceBundle::GetSharedInstance().GetNativeImageNamed(
       IDR_INFOBAR_PLUGIN_INSTALL);
 }
 
 string16 PluginInfoBarDelegate::GetLinkText() const {
   return l10n_util::GetStringUTF16(IDS_LEARN_MORE);
 }
 
 // UnauthorizedPluginInfoBarDelegate ------------------------------------------
 
-UnauthorizedPluginInfoBarDelegate::UnauthorizedPluginInfoBarDelegate(
+// static
+void UnauthorizedPluginInfoBarDelegate::Create(
     InfoBarService* infobar_service,
     HostContentSettingsMap* content_settings,
     const string16& utf16_name,
-    const std::string& identifier)
-    : PluginInfoBarDelegate(infobar_service, utf16_name, identifier),
-      content_settings_(content_settings) {
+    const std::string& identifier) {
+  infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+      new UnauthorizedPluginInfoBarDelegate(infobar_service, content_settings,
+                                            utf16_name, identifier)));
+
   content::RecordAction(UserMetricsAction("BlockedPluginInfobar.Shown"));
-  std::string name = UTF16ToUTF8(utf16_name);
+  std::string name(UTF16ToUTF8(utf16_name));
   if (name == PluginMetadata::kJavaGroupName)
     content::RecordAction(
         UserMetricsAction("BlockedPluginInfobar.Shown.Java"));
   else if (name == PluginMetadata::kQuickTimeGroupName)
     content::RecordAction(
         UserMetricsAction("BlockedPluginInfobar.Shown.QuickTime"));
   else if (name == PluginMetadata::kShockwaveGroupName)
     content::RecordAction(
         UserMetricsAction("BlockedPluginInfobar.Shown.Shockwave"));
   else if (name == PluginMetadata::kRealPlayerGroupName)
     content::RecordAction(
         UserMetricsAction("BlockedPluginInfobar.Shown.RealPlayer"));
   else if (name == PluginMetadata::kWindowsMediaPlayerGroupName)
     content::RecordAction(
         UserMetricsAction("BlockedPluginInfobar.Shown.WindowsMediaPlayer"));
 }
 
+UnauthorizedPluginInfoBarDelegate::UnauthorizedPluginInfoBarDelegate(
+    InfoBarService* infobar_service,
+    HostContentSettingsMap* content_settings,
+    const string16& utf16_name,
+    const std::string& identifier)
+    : PluginInfoBarDelegate(infobar_service, utf16_name, identifier),
+      content_settings_(content_settings) {
+}
+
 UnauthorizedPluginInfoBarDelegate::~UnauthorizedPluginInfoBarDelegate() {
   content::RecordAction(UserMetricsAction("BlockedPluginInfobar.Closed"));
 }
 
 std::string UnauthorizedPluginInfoBarDelegate::GetLearnMoreURL() const {
   return chrome::kBlockedPluginLearnMoreURL;
 }
 
 string16 UnauthorizedPluginInfoBarDelegate::GetMessageText() const {
   return l10n_util::GetStringFUTF16(IDS_PLUGIN_NOT_AUTHORIZED, name_);
@@ skipping 32 matching lines @@
 bool UnauthorizedPluginInfoBarDelegate::LinkClicked(
     WindowOpenDisposition disposition) {
   content::RecordAction(
       UserMetricsAction("BlockedPluginInfobar.LearnMore"));
   return PluginInfoBarDelegate::LinkClicked(disposition);
 }
 
 #if defined(ENABLE_PLUGIN_INSTALLATION)
 // OutdatedPluginInfoBarDelegate ----------------------------------------------
 
-InfoBarDelegate* OutdatedPluginInfoBarDelegate::Create(
-    content::WebContents* web_contents,
+void OutdatedPluginInfoBarDelegate::Create(
+    InfoBarService* infobar_service,
     PluginInstaller* installer,
     scoped_ptr<PluginMetadata> plugin_metadata) {
   string16 message;
   switch (installer->state()) {
     case PluginInstaller::INSTALLER_STATE_IDLE:
       message = l10n_util::GetStringFUTF16(IDS_PLUGIN_OUTDATED_PROMPT,
                                            plugin_metadata->name());
       break;
     case PluginInstaller::INSTALLER_STATE_DOWNLOADING:
       message = l10n_util::GetStringFUTF16(IDS_PLUGIN_DOWNLOADING,
                                            plugin_metadata->name());
       break;
   }
-  return new OutdatedPluginInfoBarDelegate(
-      web_contents, installer, plugin_metadata.Pass(), message);
+  infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+      new OutdatedPluginInfoBarDelegate(
+          infobar_service, installer, plugin_metadata.Pass(), message)));
 }
 
 OutdatedPluginInfoBarDelegate::OutdatedPluginInfoBarDelegate(
-    content::WebContents* web_contents,
+    InfoBarService* infobar_service,
     PluginInstaller* installer,
     scoped_ptr<PluginMetadata> plugin_metadata,
     const string16& message)
     : PluginInfoBarDelegate(
-          InfoBarService::FromWebContents(web_contents),
+          infobar_service,
           plugin_metadata->name(),
           plugin_metadata->identifier()),
       WeakPluginInstallerObserver(installer),
       plugin_metadata_(plugin_metadata.Pass()),
       message_(message) {
   content::RecordAction(UserMetricsAction("OutdatedPluginInfobar.Shown"));
   std::string name = UTF16ToUTF8(plugin_metadata_->name());
   if (name == PluginMetadata::kJavaGroupName)
     content::RecordAction(
         UserMetricsAction("OutdatedPluginInfobar.Shown.Java"));
@@ skipping 100 matching lines @@
 
 void OutdatedPluginInfoBarDelegate::ReplaceWithInfoBar(
     const string16& message) {
   // Return early if the message doesn't change. This is important in case the
   // PluginInstaller is still iterating over its observers (otherwise we would
   // keep replacing infobar delegates infinitely).
   if (message_ == message)
     return;
   if (!owner())
     return;
-  InfoBarDelegate* delegate = new PluginInstallerInfoBarDelegate(
-      owner(), installer(), plugin_metadata_->Clone(),
-      PluginInstallerInfoBarDelegate::InstallCallback(), false, message);
-  owner()->ReplaceInfoBar(this, delegate);
+  PluginInstallerInfoBarDelegate::Replace(
+      this, installer(), plugin_metadata_->Clone(), false, message);
 }
 
 // PluginInstallerInfoBarDelegate ---------------------------------------------
 
+void PluginInstallerInfoBarDelegate::Create(
+    InfoBarService* infobar_service,
+    PluginInstaller* installer,
+    scoped_ptr<PluginMetadata> plugin_metadata,
+    const InstallCallback& callback) {
+  string16 name(plugin_metadata->name());
+#if defined(OS_WIN)
+  if (base::win::IsMetroProcess()) {
+    PluginMetroModeInfoBarDelegate::Create(
+        infobar_service, PluginMetroModeInfoBarDelegate::MISSING_PLUGIN, name);
+    return;
+  }
+#endif
+  string16 message;
+  switch (installer->state()) {
+    case PluginInstaller::INSTALLER_STATE_IDLE:
+      message = l10n_util::GetStringFUTF16(
+          IDS_PLUGININSTALLER_INSTALLPLUGIN_PROMPT, name);
+      break;
+    case PluginInstaller::INSTALLER_STATE_DOWNLOADING:
+      message = l10n_util::GetStringFUTF16(IDS_PLUGIN_DOWNLOADING, name);
+      break;
+  }
+  infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+      new PluginInstallerInfoBarDelegate(
+          infobar_service, installer, plugin_metadata.Pass(), callback, true,
+          message)));
+}
+
+void PluginInstallerInfoBarDelegate::Replace(
+    InfoBarDelegate* infobar,
+    PluginInstaller* installer,
+    scoped_ptr<PluginMetadata> plugin_metadata,
+    bool new_install,
+    const string16& message) {
+  DCHECK(infobar->owner());
+  infobar->owner()->ReplaceInfoBar(infobar, scoped_ptr<InfoBarDelegate>(
+      new PluginInstallerInfoBarDelegate(
+          infobar->owner(), installer, plugin_metadata.Pass(),
+          PluginInstallerInfoBarDelegate::InstallCallback(), new_install,
+          message)));
+}
+
 PluginInstallerInfoBarDelegate::PluginInstallerInfoBarDelegate(
     InfoBarService* infobar_service,
     PluginInstaller* installer,
     scoped_ptr<PluginMetadata> plugin_metadata,
     const InstallCallback& callback,
     bool new_install,
     const string16& message)
     : ConfirmInfoBarDelegate(infobar_service),
       WeakPluginInstallerObserver(installer),
       plugin_metadata_(plugin_metadata.Pass()),
       callback_(callback),
       new_install_(new_install),
       message_(message) {
 }
 
 PluginInstallerInfoBarDelegate::~PluginInstallerInfoBarDelegate() {
 }
 
-InfoBarDelegate* PluginInstallerInfoBarDelegate::Create(
-    InfoBarService* infobar_service,
-    PluginInstaller* installer,
-    scoped_ptr<PluginMetadata> plugin_metadata,
-    const InstallCallback& callback) {
-  string16 message;
-  switch (installer->state()) {
-    case PluginInstaller::INSTALLER_STATE_IDLE:
-      message = l10n_util::GetStringFUTF16(
-          IDS_PLUGININSTALLER_INSTALLPLUGIN_PROMPT, plugin_metadata->name());
-      break;
-    case PluginInstaller::INSTALLER_STATE_DOWNLOADING:
-      message = l10n_util::GetStringFUTF16(IDS_PLUGIN_DOWNLOADING,
-                                           plugin_metadata->name());
-      break;
-  }
-  return new PluginInstallerInfoBarDelegate(
-      infobar_service, installer, plugin_metadata.Pass(),
-      callback, true, message);
-}
-
 gfx::Image* PluginInstallerInfoBarDelegate::GetIcon() const {
   return &ResourceBundle::GetSharedInstance().GetNativeImageNamed(
       IDR_INFOBAR_PLUGIN_INSTALL);
 }
 
 string16 PluginInstallerInfoBarDelegate::GetMessageText() const {
   return message_;
 }
 
 int PluginInstallerInfoBarDelegate::GetButtons() const {
@@ skipping 62 matching lines @@
 
 void PluginInstallerInfoBarDelegate::ReplaceWithInfoBar(
     const string16& message) {
   // Return early if the message doesn't change. This is important in case the
   // PluginInstaller is still iterating over its observers (otherwise we would
   // keep replacing infobar delegates infinitely).
   if (message_ == message)
     return;
   if (!owner())
     return;
-  InfoBarDelegate* delegate = new PluginInstallerInfoBarDelegate(
-      owner(), installer(), plugin_metadata_->Clone(),
-      InstallCallback(), new_install_, message);
-  owner()->ReplaceInfoBar(this, delegate);
+  Replace(this, installer(), plugin_metadata_->Clone(), new_install_, message);
 }
 
 // PluginMetroModeInfoBarDelegate ---------------------------------------------
 #if defined(OS_WIN)
+// static
+void PluginMetroModeInfoBarDelegate::Create(
+    InfoBarService* infobar_service,
+    PluginMetroModeInfoBarDelegate::Mode mode,
+    const string16& name) {
+  infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+      new PluginMetroModeInfoBarDelegate(infobar_service, mode, name)));
+}
+
 PluginMetroModeInfoBarDelegate::PluginMetroModeInfoBarDelegate(
     InfoBarService* infobar_service,
     PluginMetroModeInfoBarDelegate::Mode mode,
     const string16& name)
     : ConfirmInfoBarDelegate(infobar_service),
       mode_(mode),
       name_(name) {
 }
 
 PluginMetroModeInfoBarDelegate::~PluginMetroModeInfoBarDelegate() {
@@ skipping 54 matching lines @@
           "https://support.google.com/chrome/?ib_display_in_desktop" :
           "https://support.google.com/chrome/?ib_redirect_to_desktop"),
       Referrer(),
       (disposition == CURRENT_TAB) ? NEW_FOREGROUND_TAB : disposition,
       content::PAGE_TRANSITION_LINK, false);
   owner()->GetWebContents()->OpenURL(params);
   return false;
 }
 #endif  // defined(OS_WIN)
 #endif  // defined(ENABLE_PLUGIN_INSTALLATION)