Change infobar creation to use a public static Create() method on the infobar delegate classes.

chrome/browser/pepper_broker_infobar_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/pepper_broker_infobar_delegate.h"
 
 #include "chrome/browser/api/infobars/infobar_service.h"
 #include "chrome/browser/content_settings/host_content_settings_map.h"
 #include "chrome/browser/plugins/plugin_finder.h"
 #include "chrome/browser/plugins/plugin_metadata.h"
@@ skipping 14 matching lines @@
 
 // The URL for the "learn more" article about the PPAPI broker.
 const char kPpapiBrokerLearnMoreUrl[] =
     "https://support.google.com/chrome/?p=ib_pepper_broker";
 
 using content::OpenURLParams;
 using content::Referrer;
 using content::WebContents;
 
 // static
-void PepperBrokerInfoBarDelegate::Show(
+void PepperBrokerInfoBarDelegate::Create(
     WebContents* web_contents,
     const GURL& url,
     const FilePath& plugin_path,
     const base::Callback<void(bool)>& callback) {
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
   // TODO(wad): Add ephemeral device ID support for broker in guest mode.
   if (profile->IsGuestSession()) {
     callback.Run(false);
     return;
@@ skipping 19 matching lines @@
       break;
     }
     case CONTENT_SETTING_ASK: {
       content::RecordAction(
           content::UserMetricsAction("PPAPI.BrokerInfobarDisplayed"));
 
       InfoBarService* infobar_service =
           InfoBarService::FromWebContents(web_contents);
       std::string languages =
           profile->GetPrefs()->GetString(prefs::kAcceptLanguages);
-      infobar_service->AddInfoBar(
+      infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
           new PepperBrokerInfoBarDelegate(
               infobar_service, url, plugin_path, languages, content_settings,
-              callback));
+              callback)));
       break;
     }
     default:
       NOTREACHED();
   }
 }
 
-PepperBrokerInfoBarDelegate::PepperBrokerInfoBarDelegate(
-    InfoBarService* infobar_service,
-    const GURL& url,
-    const FilePath& plugin_path,
-    const std::string& languages,
-    HostContentSettingsMap* content_settings,
-    const base::Callback<void(bool)>& callback)
-    : ConfirmInfoBarDelegate(infobar_service),
-      url_(url),
-      plugin_path_(plugin_path),
-      languages_(languages),
-      content_settings_(content_settings),
-      callback_(callback) {
-}
-
-PepperBrokerInfoBarDelegate::~PepperBrokerInfoBarDelegate() {
-  if (!callback_.is_null())
-    callback_.Run(false);
-}
-
 string16 PepperBrokerInfoBarDelegate::GetMessageText() const {
   content::PluginService* plugin_service =
       content::PluginService::GetInstance();
   webkit::WebPluginInfo plugin;
   bool success = plugin_service->GetPluginInfoByPath(plugin_path_, &plugin);
   DCHECK(success);
   scoped_ptr<PluginMetadata> plugin_metadata(
       PluginFinder::GetInstance()->GetPluginMetadata(plugin));
   return l10n_util::GetStringFUTF16(IDS_PEPPER_BROKER_MESSAGE,
                                     plugin_metadata->name(),
@@ skipping 41 matching lines @@
       false);
   owner()->GetWebContents()->OpenURL(params);
   return false;
 }
 
 gfx::Image* PepperBrokerInfoBarDelegate::GetIcon() const {
   return &ResourceBundle::GetSharedInstance().GetNativeImageNamed(
       IDR_INFOBAR_PLUGIN_INSTALL);
 }
 
+PepperBrokerInfoBarDelegate::PepperBrokerInfoBarDelegate(
+    InfoBarService* infobar_service,
+    const GURL& url,
+    const FilePath& plugin_path,
+    const std::string& languages,
+    HostContentSettingsMap* content_settings,
+    const base::Callback<void(bool)>& callback)
+    : ConfirmInfoBarDelegate(infobar_service),
+      url_(url),
+      plugin_path_(plugin_path),
+      languages_(languages),
+      content_settings_(content_settings),
+      callback_(callback) {
+}
+
+PepperBrokerInfoBarDelegate::~PepperBrokerInfoBarDelegate() {
+  if (!callback_.is_null())
+    callback_.Run(false);
+}
+
 void PepperBrokerInfoBarDelegate::DispatchCallback(bool result) {
   content::RecordAction(result ?
       content::UserMetricsAction("PPAPI.BrokerInfobarClickedAllow") :
       content::UserMetricsAction("PPAPI.BrokerInfobarClickedDeny"));
   callback_.Run(result);
   callback_ = base::Callback<void(bool)>();
   content_settings_->SetContentSetting(
       ContentSettingsPattern::FromURLNoWildcard(url_),
       ContentSettingsPattern::Wildcard(),
       CONTENT_SETTINGS_TYPE_PPAPI_BROKER,
       std::string(), result ? CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK);
 }