Change infobar creation to use a public static Create() method on the infobar delegate classes.

chrome/browser/extensions/app_notify_channel_ui_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/app_notify_channel_ui_impl.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/api/infobars/confirm_infobar_delegate.h"
 #include "chrome/browser/api/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 15 matching lines @@
 #include "content/public/browser/notification_types.h"
 #include "grit/generated_resources.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace extensions {
 
 namespace {
 
 class AppNotifyChannelUIInfoBarDelegate : public ConfirmInfoBarDelegate {
  public:
-  AppNotifyChannelUIInfoBarDelegate(AppNotifyChannelUIImpl* creator,
-                                    InfoBarService* infobar_service,
-                                    const std::string& app_name);
-  virtual ~AppNotifyChannelUIInfoBarDelegate();
+  // Creates an app notify channel UI delegate and adds it to |infobar_service|.
+  static void Create(InfoBarService* infobar_service,
+                     AppNotifyChannelUIImpl* creator,
+                     const std::string& app_name);
 
   // ConfirmInfoBarDelegate.
   virtual string16 GetMessageText() const OVERRIDE;
   virtual string16 GetButtonLabel(InfoBarButton button) const OVERRIDE;
   virtual bool Accept() OVERRIDE;
   virtual bool Cancel() OVERRIDE;
   virtual void InfoBarDismissed() OVERRIDE;
 
  private:
+  AppNotifyChannelUIInfoBarDelegate(AppNotifyChannelUIImpl* creator,
+                                    InfoBarService* infobar_service,
+                                    const std::string& app_name);
+  virtual ~AppNotifyChannelUIInfoBarDelegate();
+
   AppNotifyChannelUIImpl* creator_;
   std::string app_name_;
 
   DISALLOW_COPY_AND_ASSIGN(AppNotifyChannelUIInfoBarDelegate);
 };
 
-AppNotifyChannelUIInfoBarDelegate::AppNotifyChannelUIInfoBarDelegate(
-    AppNotifyChannelUIImpl* creator,
-    InfoBarService* infobar_service,
-    const std::string& app_name)
-    : ConfirmInfoBarDelegate(infobar_service),
-      creator_(creator),
-      app_name_(app_name) {
-}
-
-AppNotifyChannelUIInfoBarDelegate::~AppNotifyChannelUIInfoBarDelegate() {
+// static
+void AppNotifyChannelUIInfoBarDelegate::Create(InfoBarService* infobar_service,
+                                               AppNotifyChannelUIImpl* creator,
+                                               const std::string& app_name) {
+  infobar_service->AddInfoBar(scoped_ptr<InfoBarDelegate>(
+      new AppNotifyChannelUIInfoBarDelegate(creator, infobar_service,
+                                            app_name)));
 }
 
 string16 AppNotifyChannelUIInfoBarDelegate::GetMessageText() const {
   return l10n_util::GetStringFUTF16(IDS_APP_NOTIFICATION_NEED_SIGNIN,
                                     UTF8ToUTF16(app_name_));
 }
 
 string16 AppNotifyChannelUIInfoBarDelegate::GetButtonLabel(
     InfoBarButton button) const {
   if (button == BUTTON_OK) {
@@ skipping 13 matching lines @@
 
 bool AppNotifyChannelUIInfoBarDelegate::Cancel() {
   creator_->OnInfoBarResult(false);
   return true;
 }
 
 void AppNotifyChannelUIInfoBarDelegate::InfoBarDismissed() {
   Cancel();
 }
 
+AppNotifyChannelUIInfoBarDelegate::AppNotifyChannelUIInfoBarDelegate(
+    AppNotifyChannelUIImpl* creator,
+    InfoBarService* infobar_service,
+    const std::string& app_name)
+    : ConfirmInfoBarDelegate(infobar_service),
+      creator_(creator),
+      app_name_(app_name) {
+}
+
+AppNotifyChannelUIInfoBarDelegate::~AppNotifyChannelUIInfoBarDelegate() {
+}
+
 }  // namespace
 
 
 AppNotifyChannelUIImpl::AppNotifyChannelUIImpl(
     Profile* profile,
     content::WebContents* web_contents,
     const std::string& app_name,
     AppNotifyChannelUI::UIType ui_type)
     : profile_(profile->GetOriginalProfile()),
       web_contents_(web_contents),
@@ skipping 27 matching lines @@
           profile_)) {
     delegate_->OnSyncSetupResult(false);
     return;
   }
 
   if (ui_type_ == NO_INFOBAR) {
     OnInfoBarResult(true);
     return;
   }
 
-  InfoBarService* infobar_service =
-      InfoBarService::FromWebContents(web_contents_);
-  infobar_service->AddInfoBar(new AppNotifyChannelUIInfoBarDelegate(
-      this, infobar_service, app_name_));
+  AppNotifyChannelUIInfoBarDelegate::Create(
+      InfoBarService::FromWebContents(web_contents_), this, app_name_);
 }
 
 void AppNotifyChannelUIImpl::OnInfoBarResult(bool accepted) {
   if (!accepted) {
     delegate_->OnSyncSetupResult(false);
     return;
   }
 
   StartObservingSync();
   // Bring up the login page.
@@ skipping 49 matching lines @@
 }
 
 void AppNotifyChannelUIImpl::StopObservingSync() {
   CHECK(observing_sync_);
   observing_sync_ = false;
   ProfileSyncServiceFactory::GetInstance()->GetForProfile(
       profile_)->RemoveObserver(this);
 }
 
 }  // namespace extensions