chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc - Issue 11644057: Move BrowserAction out of Extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action

Patch Set: Latest master for CQ Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc ('k') | chrome/common/extensions/api/omnibox/omnibox_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc b/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

similarity index 76%

rename from chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc

rename to chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

index b77092b3a03e108420e70c46b8155c0fbe2a7dbd..f19e37e201f752e26d07fa3e32f39ac23063e2bc 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc

+++ b/chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc

@@ -4,13 +4,15 @@

#include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"

+#include "chrome/common/extensions/api/extension_action/action_info.h"

+#include "chrome/common/extensions/extension.h"

#include "chrome/common/extensions/extension_manifest_constants.h"

#include "testing/gtest/include/gtest/gtest.h"

-namespace errors = extension_manifest_errors;

+namespace extensions {

TEST_F(ExtensionManifestTest, PageActionManifestVersion2) {

- scoped_refptr<extensions::Extension> extension(

+ scoped_refptr<Extension> extension(

LoadAndExpectSuccess("page_action_manifest_version_2.json"));

ASSERT_TRUE(extension.get());

ASSERT_TRUE(extension->page_action_info());

@@ -21,5 +23,7 @@ TEST_F(ExtensionManifestTest, PageActionManifestVersion2) {

EXPECT_TRUE(extension->page_action_info()->default_popup_url.is_empty());

LoadAndExpectError("page_action_manifest_version_2b.json",

- errors::kInvalidPageActionPopup);

+ extension_manifest_errors::kInvalidPageActionPopup);

}

+} // namespace extensions