chrome/renderer/extensions/page_actions_custom_bindings.cc - Issue 11644057: Move BrowserAction out of Extension

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/extensions/page_actions_custom_bindings.cc

Issue 11644057: Move BrowserAction out of Extension (Closed) Base URL: http://git.chromium.org/chromium/src.git@dc_ungoop_extension_action

Patch Set: Combined ActionInfo wrappers Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/common/extensions/manifest_tests/extension_manifests_pageaction_unittest.cc ('K') | « chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc ('k') | chrome/utility/chrome_content_utility_client.cc » ('j') | chrome/utility/chrome_content_utility_client.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/renderer/extensions/page_actions_custom_bindings.h"	5 #include "chrome/renderer/extensions/page_actions_custom_bindings.h"

6	6

7 #include <string>	7 #include <string>

8	8

	9 #include "chrome/common/extensions/api/extension_action/action_info.h"
	Yoyo Zhou 2012/12/28 05:19:59 ditto ditto Devlin 2012/12/28 20:25:36 ditto :) (line 35) Show quoted text On 2012/12/28 05:19:59, Yoyo Zhou wrote: > ditto ditto :) (line 35)
9 #include "chrome/renderer/extensions/dispatcher.h"	10 #include "chrome/renderer/extensions/dispatcher.h"

10 #include "grit/renderer_resources.h"	11 #include "grit/renderer_resources.h"

11 #include "v8/include/v8.h"	12 #include "v8/include/v8.h"

12	13

13 namespace extensions {	14 namespace extensions {

14	15

15 PageActionsCustomBindings::PageActionsCustomBindings(	16 PageActionsCustomBindings::PageActionsCustomBindings(

16 Dispatcher* dispatcher)	17 Dispatcher* dispatcher)

17 : ChromeV8Extension(dispatcher) {	18 : ChromeV8Extension(dispatcher) {

18 RouteStaticFunction("GetCurrentPageActions", &GetCurrentPageActions);	19 RouteStaticFunction("GetCurrentPageActions", &GetCurrentPageActions);

(...skipping 14 matching lines...) Expand all Loading...
33 if (extension->page_action_info()) {	34 if (extension->page_action_info()) {

34 std::string id = extension->page_action_info()->id;	35 std::string id = extension->page_action_info()->id;

35 page_action_vector->Set(v8::Integer::New(0),	36 page_action_vector->Set(v8::Integer::New(0),

36 v8::String::New(id.c_str(), id.size()));	37 v8::String::New(id.c_str(), id.size()));

37 }	38 }

38	39

39 return page_action_vector;	40 return page_action_vector;

40 }	41 }

41	42

42 } // extensions	43 } // extensions

OLD	NEW