Move BrowserAction out of Extension

chrome/common/extensions/api/extension_action/action_info.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_
 #define CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_
 
 #include <string>
 
+#include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_icon_set.h"
 #include "googleurl/src/gurl.h"
 
 namespace extensions {
 
 struct ActionInfo {
   ActionInfo();
   ~ActionInfo();
 
   // The types of extension actions.
   enum Type {
     TYPE_BROWSER,
     TYPE_PAGE,
     TYPE_SCRIPT_BADGE,
     TYPE_SYSTEM_INDICATOR,
   };
 
   // Empty implies the key wasn't present.
   ExtensionIconSet default_icon;
   std::string default_title;
   GURL default_popup_url;
   // action id -- only used with legacy page actions API.
   std::string id;
 };
 
+// The manifest data container for the ActionInfos for BrowserActions and
+// ScriptBadges.
+struct ActionInfoData : public Extension::ManifestData {

[Yoyo Zhou, 2012/12/28 05:19:59]

Can you hide this in the anonymous namespace in the .cc? It's not necessary to
expose this part of the implementation.

[Devlin, 2012/12/28 20:25:36]

Possible, as long as we also put in Set|BrowserAction,ScriptBadge|Info methods;
done.

+  explicit ActionInfoData(ActionInfo* action_info);
+  virtual ~ActionInfoData();
+
+  // The action associated with the BrowserAction or ScriptBadge.
+  // This is never NULL for ScriptBadge.
+  scoped_ptr<ActionInfo> action_info;
+
+  // Returns the appropriate ActionInfo for the extension.
+  static const ActionInfo* GetBrowserActionInfo(const Extension* extension);

[Yoyo Zhou, 2012/12/28 05:19:59]

Can you put these in ActionInfo? It reads better than ActionInfoData in the
interface, especially since you get an ActionInfo*.

[Devlin, 2012/12/28 20:25:36]

Agreed, and done.

+  static const ActionInfo* GetScriptBadgeInfo(const Extension* extension);
+};
+
 }  // namespace extensions
 
 #endif  // CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_ACTION_INFO_H_