Issue 11644053: Fixing core exception tests after Chrome update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11644053: Fixing core exception tests after Chrome update. (Closed)

Created:
8 years ago by blois

Modified:
8 years ago

Reviewers:
sra1

CC:
reviews_dartlang.org, compiler-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing core exception tests after Chrome update. Related to https://codereview.chromium.org/11645050/, additional core tests were broken as well. Basically Dart is relying on the JS exception's message to unwrap into a Dart exception, but this appears to be quite unstable. BUG= Committed: https://code.google.com/p/dart/source/detail?r=16399

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

lgtm