chrome/browser/ui/omnibox/omnibox_edit_model.cc - Issue 11644050: [Search] Avoid crash when hitting Esc in the Omnibox

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 11644050: [Search] Avoid crash when hitting Esc in the Omnibox (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: reupload Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc

diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

index 7229b5872b8edab1725d8e7ffc6eeefa7fedeb0d..3f224585b0cde19ce60cb9e40bf5772087c1c460 100644

--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc

+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc

@@ -793,7 +793,7 @@ void OmniboxEditModel::OnKillFocus() {

}

bool OmniboxEditModel::OnEscapeKeyPressed() {

- if (has_temporary_text_) {

+ if (has_temporary_text_ && !is_temporary_text_set_by_instant_) {

AutocompleteMatch match;

InfoForCurrentSelection(&match, NULL);

if (match.destination_url != original_url_) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »