Issue 11644021: Fix treatment of hidden prototypes in SetProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11644021: Fix treatment of hidden prototypes in SetProperty. (Closed)

Created:
8 years ago by rossberg

Modified:
8 years ago

Reviewers:
Sven Panne

CC:
v8-dev, adamk

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix treatment of hidden prototypes in SetProperty. R=svenpanne@chromium.org BUG=v8:2457 Committed: http://code.google.com/p/v8/source/detail?r=13245

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix warning #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -20 lines)			Patch
	M	src/objects.cc	View		5 chunks	+19 lines, -20 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

8 years ago (2012-12-19 14:33:43 UTC) #2

lgtm

https://codereview.chromium.org/11644021/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/11644021/diff/1/src/objects.cc#newcode2983
src/objects.cc:2983: return self->SetPropertyWithCallback(
As discussed offline, "self" is hopefully the right thing to use here. :-)

Expand Messages | Collapse Messages