Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2464)

Unified Diff: chrome/browser/instant/instant_controller.h

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/instant_controller.h
diff --git a/chrome/browser/instant/instant_controller.h b/chrome/browser/instant/instant_controller.h
index e6abd1a168bdfa452c3eb7a06dea50afc1ce5b84..b74f8d9d06bf0b965eb43c72fb0b19d105725ab3 100644
--- a/chrome/browser/instant/instant_controller.h
+++ b/chrome/browser/instant/instant_controller.h
@@ -25,6 +25,7 @@
#include "chrome/common/search_types.h"
#include "content/public/common/page_transition_types.h"
#include "googleurl/src/gurl.h"
+#include "ui/base/window_open_disposition.h"
#include "ui/gfx/native_widget_types.h"
#include "ui/gfx/rect.h"
@@ -189,6 +190,7 @@ class InstantController : public InstantPage::Delegate {
FRIEND_TEST_ALL_PREFIXES(InstantTest, InstantOverlayRefresh);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ExtendedModeIsOn);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, OmniboxFocusLoadsInstant);
+ FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, MiddleClickOnSuggestionOpensInNewTab);
sreeram 2013/02/20 22:53:32 80-column limit.
dougw 2013/02/20 23:35:11 Done.
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, NTPIsPreloaded);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInNewTab);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInSameTab);
@@ -221,7 +223,8 @@ class InstantController : public InstantPage::Delegate {
virtual void NavigateToURL(
const content::WebContents* contents,
const GURL& url,
- content::PageTransition transition) OVERRIDE;
+ content::PageTransition transition,
+ WindowOpenDisposition disposition) OVERRIDE;
// Helper for OmniboxFocusChanged. Commit or discard the preview.
void OmniboxLostFocus(gfx::NativeView view_gaining_focus);
« no previous file with comments | « no previous file | chrome/browser/instant/instant_controller.cc » ('j') | chrome/browser/instant/instant_extended_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698