Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8652)

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/searchbox/searchbox_extension.cc
diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc
index 8233bda3e4de560c899d0bc2d3c89a10cef68556..a97a2fa0178224bdd803dfcb5aa27ad336c6e3c3 100644
--- a/chrome/renderer/searchbox/searchbox_extension.cc
+++ b/chrome/renderer/searchbox/searchbox_extension.cc
@@ -18,6 +18,7 @@
#include "ui/base/keycodes/keyboard_codes.h"
#include "ui/base/resource/resource_bundle.h"
#include "v8/include/v8.h"
+#include "ui/base/window_open_disposition.h"
samarth 2013/02/20 23:55:16 nit: sort please
dougw 2013/02/21 00:49:00 Done.
namespace {
@@ -675,9 +676,13 @@ v8::Handle<v8::Value> SearchBoxExtensionWrapper::NavigateContentWindow(
}
// Navigate the main frame.
- if (destination_url.is_valid())
- SearchBox::Get(render_view)->NavigateToURL(destination_url, transition);
-
+ if (destination_url.is_valid()) {
+ WindowOpenDisposition disposition = CURRENT_TAB;
+ if (args[1]->Uint32Value() == 2)
+ disposition = NEW_BACKGROUND_TAB;
+ SearchBox::Get(render_view)->NavigateToURL(
+ destination_url, transition, disposition);
+ }
return v8::Undefined();
}

Powered by Google App Engine
This is Rietveld 408576698