chrome/browser/ui/browser_instant_controller.h - Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_instant_controller.h

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_browsertest.cc ('K') | « chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js ('k') | chrome/browser/ui/browser_instant_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_instant_controller.h

diff --git a/chrome/browser/ui/browser_instant_controller.h b/chrome/browser/ui/browser_instant_controller.h

index f27d7e060aca997a649b1731647613e37726e88f..adbecf9828b81d457eb85267e27599c745c1388e 100644

--- a/chrome/browser/ui/browser_instant_controller.h

+++ b/chrome/browser/ui/browser_instant_controller.h

@@ -88,7 +88,9 @@ class BrowserInstantController : public content::NotificationObserver,

void UpdateThemeInfoForPreview();

// Invoked by the InstantController when it wants to open a URL.

- void OpenURLInCurrentTab(const GURL& url, content::PageTransition transition);

+ void OpenURL(const GURL& url,

+ content::PageTransition transition,

+ WindowOpenDisposition disposition);

// Sets the start and end margins of the omnibox text area.

void SetMarginSize(int start, int end);