chrome/browser/ui/browser_instant_controller.cc - Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_instant_controller.cc

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_loader.cc ('K') | « chrome/browser/ui/browser_instant_controller.h ('k') | chrome/common/render_messages.h » ('j') | chrome/renderer/searchbox/searchbox_extension.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_instant_controller.cc

diff --git a/chrome/browser/ui/browser_instant_controller.cc b/chrome/browser/ui/browser_instant_controller.cc

index 7abe3aa900015a2cc93088f32a243fdf112b7983..baa885a5193f5cb609423043dc4e3ce5d87545dc 100644

--- a/chrome/browser/ui/browser_instant_controller.cc

+++ b/chrome/browser/ui/browser_instant_controller.cc

@@ -165,12 +165,13 @@ void BrowserInstantController::UpdateThemeInfoForPreview() {

OnThemeChanged(NULL);

}

-void BrowserInstantController::OpenURLInCurrentTab(

+void BrowserInstantController::OpenURL(

const GURL& url,

- content::PageTransition transition) {

+ content::PageTransition transition,

+ WindowOpenDisposition disposition) {

browser_->OpenURL(content::OpenURLParams(url,

content::Referrer(),

- CURRENT_TAB,

+ disposition,

transition,

false));

}