chrome/browser/instant/instant_tab.h - Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/instant/instant_tab.h

Issue 11644009: Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/instant/instant_loader.cc ('K') | « chrome/browser/instant/instant_loader.cc ('k') | chrome/browser/instant/instant_tab.cc » ('j') | chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/instant/instant_tab.h

diff --git a/chrome/browser/instant/instant_tab.h b/chrome/browser/instant/instant_tab.h

index 2e0321abe3bb6926efaff9b8bb7b9ee9214bf960..f47dbd6475f6465adc3b415f7b8d9547b87cd041 100644

--- a/chrome/browser/instant/instant_tab.h

+++ b/chrome/browser/instant/instant_tab.h

@@ -11,6 +11,7 @@

#include "base/compiler_specific.h"

#include "base/string16.h"

#include "chrome/browser/instant/instant_client.h"

+#include "webkit/glue/window_open_disposition.h"

sreeram 2013/01/22 06:01:19 Same here. No need for this include.

dougw 2013/01/24 03:05:25 Done.

struct InstantAutocompleteResult;

class InstantController;

@@ -59,7 +60,8 @@ class InstantTab : public InstantClient::Delegate {

virtual void RenderViewGone() OVERRIDE;

virtual void AboutToNavigateMainFrame(const GURL& url) OVERRIDE;

virtual void NavigateToURL(const GURL& url,

- content::PageTransition transition) OVERRIDE;

+ content::PageTransition transition,

+ WindowOpenDisposition disposition) OVERRIDE;

InstantClient client_;

InstantController* const controller_;