Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+/**
+ * @fileoverview Support for omnibox behavior in offline mode or when API
+ * features are not supported on the server.
+ */
+
+// ==========================================================
+//  Enums.
+// ==========================================================
+
+/**
+ * Possible behaviors for navigateContentWindow.
+ * @enum {number}
+ * @private
+ */
+var WindowOpenDisposition_ = {

[Evan Stade, 2013/02/22 22:28:29]

why are there trailing underscores here and below?

[dougw, 2013/02/22 23:32:19]

Unless I'm mistaken (and that's very possible), the JavaScript style guide
recommends underscores for private variables.


On 2013/02/22 22:28:29, Evan Stade wrote:

+  CURRENT_TAB: 1,
+  NEW_BACKGROUND_TAB: 2
+};
+
+/**
+ * The JavaScript button event value for a middle click.
+ * @type {number}
+ * @private
+ * @const
+ */
+var MIDDLE_MOUSE_BUTTON_ = 1;
+
 // =============================================================================
 //                               Util functions
 // =============================================================================
 
 /**
  * The maximum number of suggestions to show.
  * @type {number}
  * @const
  */
 var MAX_SUGGESTIONS_TO_SHOW = 5;
@@ skipping 31 matching lines @@
   suggestionDiv.classList.add('suggestion');
   if (select)
     suggestionDiv.classList.add('selected');
 
   var contentsContainer = document.createElement('div');
   contentsContainer.className = 'contents';
   var contents = suggestion.combinedNode;
   contentsContainer.appendChild(contents);
   suggestionDiv.appendChild(contentsContainer);
   var restrictedId = suggestion.rid;
-  suggestionDiv.onclick = function() {
-    handleSuggestionClick(restrictedId);
+  suggestionDiv.onclick = function(event) {
+    handleSuggestionClick(restrictedId, event);
   };
 
   restrictedIds.push(restrictedId);
   box.appendChild(suggestionDiv);
 }
 
 /**
  * Renders the input suggestions.
  * @param {Array} nativeSuggestions An array of native suggestions to render.
  */
@@ skipping 121 matching lines @@
       '  -webkit-margin-end: ' + apiHandle.endMargin + 'px;' +
       '  font: ' + apiHandle.fontSize + 'px "' + apiHandle.font + '";' +
       '}';
   document.querySelector('head').appendChild(style);
 }
 
 /**
  * Handles suggestion clicks.
  * @param {integer} restrictedId The restricted id of the suggestion being
  *     clicked.
+ * @param {Event} event The native click event.

[Evan Stade, 2013/02/22 22:28:29]

not sure what "native" means in this context. Suggest removing this word.

[dougw, 2013/02/22 23:32:19]

Done.

  */
-function handleSuggestionClick(restrictedId) {
+function handleSuggestionClick(restrictedId, event) {
   clearSuggestions();
-  getApiObjectHandle().navigateContentWindow(restrictedId);
+  var disposition = WindowOpenDisposition_.CURRENT_TAB;
+  if (event.button == MIDDLE_MOUSE_BUTTON_)
+    disposition = WindowOpenDisposition_.NEW_BACKGROUND_TAB;
+  getApiObjectHandle().navigateContentWindow(restrictedId, disposition);
 }
 
 /**
  * chrome.searchBox.onkeypress implementation.
  * @param {Object} e The key being pressed.
  */
 function handleKeyPress(e) {
   switch (e.keyCode) {
     case 38:  // Up arrow
       updateSelectedSuggestion(false);
@@ skipping 18 matching lines @@
   apiHandle.onnativesuggestions = handleNativeSuggestions;
   apiHandle.onkeypress = handleKeyPress;
   apiHandle.onsubmit = onSubmit;
   appendSuggestionStyles();
 
   if (apiHandle.nativeSuggestions.length)
     handleNativeSuggestions();
 }
 
 document.addEventListener('DOMContentLoaded', setUpApi);