Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

chrome/browser/instant/instant_extended_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/instant/instant_loader.h"
 #include "chrome/browser/instant/instant_test_utils.h"
 #include "chrome/browser/ui/search/search.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
 
 class InstantExtendedTest : public InstantTestBase {
  protected:
   virtual void SetUpInProcessBrowserTestFixture() OVERRIDE {
     chrome::search::EnableInstantExtendedAPIForTesting();
     ASSERT_TRUE(test_server()->Start());
     instant_url_ = test_server()->GetURL("files/instant_extended.html");
   }
@@ skipping 55 matching lines @@
   content::WebContents* preview_tab = instant()->GetPreviewContents();
   EXPECT_TRUE(preview_tab);
   EXPECT_FALSE(instant()->IsPreviewingSearchResults());
   EXPECT_TRUE(instant()->model()->mode().is_default());
 
   // Typing in the omnibox should show the overlay.
   SetOmniboxTextAndWaitForInstantToShow("query");
   EXPECT_TRUE(instant()->model()->mode().is_search_suggestions());
   EXPECT_EQ(preview_tab, instant()->GetPreviewContents());
 }
+
+// Test that middle clicking on a suggestion opens the result in a new tab.
+IN_PROC_BROWSER_TEST_F(InstantExtendedTest, MiddleClickOnSuggestionOpensInNewTab) {

[sreeram, 2013/01/24 19:13:48]

80 column limit

[dougw, 2013/02/06 21:42:11]

Done.

+  ASSERT_NO_FATAL_FAILURE(SetupInstant());
+  FocusOmniboxAndWaitForInstantSupport();
+
+  GURL url(std::string("http://google.com"));

[sreeram, 2013/01/24 19:13:48]

You should assert here, before the navigation, that there's just 1 tab.

[dougw, 2013/02/06 21:42:11]

Done.

+  instant()->NavigateToURL(url, content::PAGE_TRANSITION_TYPED, NEW_BACKGROUND_TAB);

[sreeram, 2013/01/24 19:13:48]

80 column limit

[sreeram, 2013/01/24 19:13:48]

I think you should actually click on the page so that we can test that the API
and IPC are properly exercised.

[dougw, 2013/02/06 21:42:11]

Done.

[dougw, 2013/02/20 21:46:56]

Done.

[dougw, 2013/02/20 21:46:56]

Done.

+
+  // Check that we have two tabs and that the new active tab is indeed what was
+  // once the preview. The preview tab should have just one navigation entry,
+  // for the Instant search that was committed.
+  EXPECT_EQ(2, browser()->tab_strip_model()->count());

[sreeram, 2013/01/24 19:13:48]

You're not EXPECT()ing all the things the comment is talking about.

[dougw, 2013/02/06 21:42:11]

Done.

+}