Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// ==========================================================
+//  Enums.
+// ==========================================================
+/**
+ * Possible behaviors for navigateContentWindow.
+ * @enum {number}
+ * @private
+ */
+var WindowOpenDisposition_ = {
+  CURRENT_TAB: 1,
+  NEW_BACKGROUND_TAB: 2
+};
+
+// ==========================================================
+//  Component dependencies.

[sreeram, 2013/01/22 06:01:19]

Huh? That's a strange name. Also, why define this section if it's not being
used? Surely you can do so when you actually add support for the middle mouse
button?

[samarth, 2013/01/22 16:13:32]

Agreed. As you have it right now, you could just leave off the disposition
argument completely and it'll continue opening in the current tab. If you want
to add support for the middle mouse button here, that's fine as well.

[dougw, 2013/01/24 03:05:25]

Done.

[dougw, 2013/01/24 03:05:25]

Done.

+// ==========================================================
+/**
+ * @type {number}
+ * @private
+ * @const
+ */
+var MIDDLE_MOUSE_BUTTON_ = 1;
+
 // =============================================================================
 //                               Util functions
 // =============================================================================
 
 /**
  * The maximum number of suggestions to show.
  * @type {number}
  * @const
  */
 var MAX_SUGGESTIONS_TO_SHOW = 5;
@@ skipping 180 matching lines @@
   document.querySelector('head').appendChild(style);
 }
 
 /**
  * Handles suggestion clicks.
  * @param {integer} restrictedId The restricted id of the suggestion being
  *     clicked.
  */
 function handleSuggestionClick(restrictedId) {
   clearSuggestions();
-  getApiObjectHandle().navigateContentWindow(restrictedId);
+  var disposition = WindowOpenDisposition_.CURRENT_TAB;
+  getApiObjectHandle().navigateContentWindow(
+      restrictedId, disposition);
 }
 
 /**
  * chrome.searchBox.onkeypress implementation.
  * @param {Object} e The key being pressed.
  */
 function handleKeyPress(e) {
   switch (e.keyCode) {
     case 38:  // Up arrow
       updateSelectedSuggestion(false);
@@ skipping 14 matching lines @@
  * Sets up the searchBox API.
  */
 function setUpApi() {
   var apiHandle = getApiObjectHandle();
   apiHandle.onnativesuggestions = handleNativeSuggestions;
   apiHandle.onkeypress = handleKeyPress;
   apiHandle.onsubmit = onSubmit;
 }
 
 document.addEventListener('DOMContentLoaded', setUpApi);