Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

chrome/renderer/searchbox/searchbox_extension.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox_extension.h"
 
 #include "base/i18n/rtl.h"
 #include "base/string_number_conversions.h"
 #include "base/stringprintf.h"
 #include "chrome/common/extensions/extension.h"
 #include "chrome/renderer/searchbox/searchbox.h"
 #include "content/public/renderer/render_view.h"
 #include "grit/renderer_resources.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebScriptSource.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebView.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebURLRequest.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "v8/include/v8.h"
+#include "webkit/glue/window_open_disposition.h"
+
 
 namespace {
 
 const char kCSSBackgroundImageFormat[] =
     "-webkit-image-set(url(chrome://theme/IDR_THEME_BACKGROUND?%s) 1x)";
 
 const char kCSSBackgroundColorFormat[] = "rgba(%d,%d,%d,%s)";
 
 const char kCSSBackgroundPositionCenter[] = "center";
 const char kCSSBackgroundPositionLeft[] = "left";
@@ skipping 660 matching lines @@
         GetAutocompleteResultWithId(args[0]->Uint32Value());
     if (result) {
       destination_url = GURL(result->destination_url);
       transition = result->transition;
     }
   } else {
     destination_url = GURL(V8ValueToUTF16(args[0]));
   }
 
   // Navigate the main frame.
-  if (destination_url.is_valid())
-    SearchBox::Get(render_view)->NavigateToURL(destination_url, transition);
-
+  if (destination_url.is_valid()) {
+    if (args[1]->Uint32Value() == NEW_BACKGROUND_TAB) {

[samarth, 2013/01/10 21:42:04]

Is disposition supposed to be optional?  Do you need to also check for
IsUint32()?

[samarth, 2013/01/10 21:42:04]

Don't use NEW_BACKGROUND_TAB here. We don't want the api changing just in case
the enum changes from underneath us.

How about something like:
disposition = CURRENT_TAB;
if (int32value() == 1)  // or whatever it is
  disposition = NEW_BACKGROUND_TAB;
NavigateToURL(..., disposition);

[dougw, 2013/01/18 23:54:30]

Done.

[dougw, 2013/01/18 23:54:30]

Done.

+      SearchBox::Get(render_view)->NavigateToURL(destination_url,
+                                                 transition,
+                                                 NEW_BACKGROUND_TAB);
+    } else {
+      SearchBox::Get(render_view)->NavigateToURL(destination_url,
+                                                 transition,
+                                                 CURRENT_TAB);
+    }
+  }
   return v8::Undefined();
 }
 
 // static
 v8::Handle<v8::Value> SearchBoxExtensionWrapper::SetSuggestions(
     const v8::Arguments& args) {
   content::RenderView* render_view = GetRenderView();
   if (!render_view || !args.Length()) return v8::Undefined();
 
   DVLOG(1) << render_view << " SetSuggestions";
@@ skipping 244 matching lines @@
   Dispatch(frame, kDispatchThemeAreaHeightChangeEventScript);
 }
 
 // static
 v8::Extension* SearchBoxExtension::Get() {
   return new SearchBoxExtensionWrapper(ResourceBundle::GetSharedInstance().
       GetRawDataResource(IDR_SEARCHBOX_API));
 }
 
 }  // namespace extensions_v8