Added support for passing WindowOpenDisposition into BrowserInstantController::OpenURL() from the o…

chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.js

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// ==========================================================
+//  Enums.
+// ==========================================================
+/**
+* The desired behavior for navigateContentWindow.
+* @enum {string}
+* @private
+*/
+var WindowOpenDisposition_ = {

[samarth, 2013/01/10 21:42:04]

How come this doesn't match the other enum?

[dougw, 2013/01/18 23:54:30]

Done.

+  UNKNOWN: 'a',
+  SUPPRESS_OPEN: 'b',
+  CURRENT_TAB: 'c',
+  // Indicates that only one tab with the url should exist in the same window.
+  SINGLETON_TAB: 'd',
+  NEW_FOREGROUND_TAB: 'e',
+  NEW_BACKGROUND_TAB: 'f',
+  NEW_POPUP: 'g',
+  NEW_WINDOW: 'h',
+  SAVE_TO_DISK: 'i',
+  OFF_THE_RECORD: 'j',
+  IGNORE_ACTION: 'k'
+};
+
 // =============================================================================
 //                               Util functions
 // =============================================================================
 
 // The maximum number of suggestions to show.
 var MAX_SUGGESTIONS_TO_SHOW = 5;
 
 /**
  * Displays a suggestion.
  * @param {Object} suggestion The suggestion to render.
@@ skipping 148 matching lines @@
 }
 
 /**
  * Handles suggestion clicks.
  * @param {integer} restrictedId The restricted id of the suggestion being
  *     clicked.
  */
 function handleSuggestionClick(restrictedId) {
   var apiHandle = getApiObjectHandle();
   clearSuggestions();
-  apiHandle.navigateContentWindow(restrictedId);
+  apiHandle.navigateContentWindow(restrictedId,
+                                  WindowOpenDisposition_.CURRENT_TAB);

[samarth, 2013/01/10 21:42:04]

Middle clicking should work correctly here as well.

[dougw, 2013/01/18 23:54:30]

I'd like to do this in a separate cl :)

 }
 
 /**
  * chrome.searchBox.onkeypress implementation.
  * @param {Object} e The key being pressed.
  */
 function handleKeyPress(e) {
   var apiHandle = getApiObjectHandle();
   function callback(restrictedId) {
     apiHandle.setRestrictedValue(restrictedId);
@@ skipping 19 matching lines @@
  * Sets up the searchBox API.
  */
 function setUpApi() {
   var apiHandle = getApiObjectHandle();
   apiHandle.onnativesuggestions = handleNativeSuggestions;
   apiHandle.onkeypress = handleKeyPress;
   apiHandle.onsubmit = onSubmit;
 }
 
 document.addEventListener('DOMContentLoaded', setUpApi);