Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3001)

Unified Diff: cc/occlusion_tracker.cc

Issue 11644008: Migrate from MathUtil::inverse() to gfx::Transform::GetInverse() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Partially addressed uninvertible cases Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/occlusion_tracker.cc
diff --git a/cc/occlusion_tracker.cc b/cc/occlusion_tracker.cc
index 406729db0bfb9ec6b0e7d35128b774db3028ef7e..623f3a7d7c1b53f6d3dc0a543c0a1476cdf5c7f6 100644
--- a/cc/occlusion_tracker.cc
+++ b/cc/occlusion_tracker.cc
@@ -56,7 +56,7 @@ void OcclusionTrackerBase<LayerType, RenderSurfaceType>::leaveLayer(const LayerI
template<typename RenderSurfaceType>
static gfx::Rect screenSpaceClipRectInTargetSurface(const RenderSurfaceType* targetSurface, gfx::Rect screenSpaceClipRect)
{
- gfx::Transform inverseScreenSpaceTransform;
+ gfx::Transform inverseScreenSpaceTransform(gfx::Transform::kSkipInitialization);
if (!targetSurface->screenSpaceTransform().GetInverse(&inverseScreenSpaceTransform))
return targetSurface->contentRect();
@@ -126,7 +126,7 @@ void OcclusionTrackerBase<LayerType, RenderSurfaceType>::enterRenderTarget(const
bool enteringSubtreeThatMovesPixels = newAncestorThatMovesPixels && newAncestorThatMovesPixels != oldAncestorThatMovesPixels;
bool haveTransformFromScreenToNewTarget = false;
- gfx::Transform inverseNewTargetScreenSpaceTransform;
+ gfx::Transform inverseNewTargetScreenSpaceTransform(gfx::Transform::kSkipInitialization); // Note carefully, not used if screen space transform is uninvertible.
if (surfaceTransformsToScreenKnown(newTarget->renderSurface()))
haveTransformFromScreenToNewTarget = newTarget->renderSurface()->screenSpaceTransform().GetInverse(&inverseNewTargetScreenSpaceTransform);
@@ -355,7 +355,7 @@ bool OcclusionTrackerBase<LayerType, RenderSurfaceType>::occluded(const LayerTyp
DCHECK(renderTarget->renderSurface());
DCHECK(renderTarget == m_stack.back().target);
- gfx::Transform inverseDrawTransform;
+ gfx::Transform inverseDrawTransform(gfx::Transform::kSkipInitialization);
if (!drawTransform.GetInverse(&inverseDrawTransform))
return false;
@@ -398,7 +398,7 @@ gfx::Rect OcclusionTrackerBase<LayerType, RenderSurfaceType>::unoccludedContentR
DCHECK(renderTarget->renderSurface());
DCHECK(renderTarget == m_stack.back().target);
- gfx::Transform inverseDrawTransform;
+ gfx::Transform inverseDrawTransform(gfx::Transform::kSkipInitialization);
if (!drawTransform.GetInverse(&inverseDrawTransform))
return contentRect;
@@ -447,7 +447,7 @@ gfx::Rect OcclusionTrackerBase<LayerType, RenderSurfaceType>::unoccludedContribu
return contentRect;
gfx::Transform drawTransform = forReplica ? surface->replicaDrawTransform() : surface->drawTransform();
- gfx::Transform inverseDrawTransform;
+ gfx::Transform inverseDrawTransform(gfx::Transform::kSkipInitialization);
if (!drawTransform.GetInverse(&inverseDrawTransform))
return contentRect;

Powered by Google App Engine
This is Rietveld 408576698