Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 1164393004: bluetooth: Layout tests for bluetooth error messages (Closed)

Created:
4 years, 10 months ago by ortuno
Modified:
4 years, 10 months ago
Reviewers:
scheib
CC:
blink-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@bluetooth-read-value-impl
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bluetooth: Layout tests for bluetooth error messages This is the third patch to add more descriptive error messages and to return different errors based on the GATT Error: [1] http://crrev.com/1179733006 [2] http://crrev.com/1177613002 [3] This patch. BUG=490419, 499542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197149

Patch Set 1 #

Patch Set 2 : Uncomment test line #

Patch Set 3 : Fix error message test since message on browser side changed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M LayoutTests/bluetooth/connectGATT.html View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/bluetooth/getCharacteristic.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/bluetooth/getPrimaryService.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/bluetooth/readValue.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/bluetooth/requestDevice.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ortuno
@scheib: PTAL
4 years, 10 months ago (2015-06-09 23:34:42 UTC) #2
scheib
LGTM
4 years, 10 months ago (2015-06-12 17:33:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1164393004/40001
4 years, 10 months ago (2015-06-16 00:32:38 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 00:35:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197149

Powered by Google App Engine
This is Rietveld 408576698