Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1164363002: Sky support for flexbox justify content (Closed)

Created:
5 years, 6 months ago by jackson
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix vertical flex positioning #

Patch Set 3 : Include test case #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -10 lines) Patch
M sky/examples/lib/solid_color_box.dart View 1 chunk +1 line, -1 line 0 comments Download
A sky/examples/raw/justify_content.dart View 1 2 1 chunk +46 lines, -0 lines 0 comments Download
M sky/sdk/lib/framework/components2/ink_well.dart View 1 chunk +4 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M sky/sdk/lib/framework/rendering/flex.dart View 1 2 5 chunks +62 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jackson
5 years, 6 months ago (2015-06-08 21:09:36 UTC) #1
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-08 21:10:52 UTC) #2
jackson
Committed patchset #4 (id:60001) manually as b44ac10b44dd1aca0c242062fc271b1da3cdb764 (presubmit successful).
5 years, 6 months ago (2015-06-08 21:14:06 UTC) #3
jackson
5 years, 6 months ago (2015-06-08 21:22:16 UTC) #4
Message was sent while issue was closed.
I'm working on changing the example to be a test instead

Powered by Google App Engine
This is Rietveld 408576698