media/blink/webmediaplayer_impl.h - Issue 1164343003: Fix WMPI::currentTime/seek race causing flaky Blink mediasource-redundant-seek.html on desktop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/webmediaplayer_impl.h

Issue 1164343003: Fix WMPI::currentTime/seek race causing flaky Blink mediasource-redundant-seek.html on desktop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/blink/webmediaplayer_impl.h

diff --git a/media/blink/webmediaplayer_impl.h b/media/blink/webmediaplayer_impl.h

index 427357b1f615fb8388c87522829dfb97085f8b09..6ad0027716e535f2f4b034f2777214d94f523ad8 100644

--- a/media/blink/webmediaplayer_impl.h

+++ b/media/blink/webmediaplayer_impl.h

@@ -286,7 +286,8 @@ class MEDIA_EXPORT WebMediaPlayerImpl

// Seek gets pending if another seek is in progress. Only last pending seek

// will have effect.

bool pending_seek_;

- double pending_seek_seconds_;

+ base::TimeDelta pending_seek_time_;

+ base::TimeDelta seek_time_;

xhwang 2015/06/09 21:33:57 Move |seek_time_| to after |seeking_|?

wolenetz 2015/06/09 22:09:58 Done, with comments added, and |playback_rate_| mo

// Tracks whether to issue time changed notifications during buffering state

// changes.

« no previous file with comments | « no previous file | media/blink/webmediaplayer_impl.cc » ('j') | media/blink/webmediaplayer_impl.cc » ('J')