ToolbarView MaterialDesign in ThemeProvider

chrome/browser/themes/theme_properties.h

Index: chrome/browser/themes/theme_properties.h
diff --git a/chrome/browser/themes/theme_properties.h b/chrome/browser/themes/theme_properties.h
index f2f9b087c074c5dde3d8c1f9b854d9e3947cfd46..65653c13f3883e8045772dc65c9167fcc9ec9019 100644
--- a/chrome/browser/themes/theme_properties.h
+++ b/chrome/browser/themes/theme_properties.h
@@ -111,8 +111,14 @@ class ThemeProperties {
     GRADIENT_TOOLBAR_BUTTON,
     GRADIENT_TOOLBAR_BUTTON_INACTIVE,
     GRADIENT_TOOLBAR_BUTTON_PRESSED,
-    GRADIENT_TOOLBAR_BUTTON_PRESSED_INACTIVE
+    GRADIENT_TOOLBAR_BUTTON_PRESSED_INACTIVE,
 #endif  // OS_MACOSX
+
+    // Layout Properties for the Toolbar

[pkotwicz, 2015/07/03 15:39:22]

Can you add a TODO to remove all of these properties from this file once Chrome
is 100% switched over to material design?

It might be useful if you started a new enum "MaterialDesignDisplayProperty"
perhaps. The benefit is that in theme_properties.cc you could get rid of a few
default cases in the switch statements. In particular:

int ThemeProperties::GetDefaultDisplayProperty(int id) {
  if (id >= MATERIAL_DESIGN_DISPLAY_PROPERTY_FIRST &&
      id <= MATERIAL_DESIGN_DISPLAY_PROPERTY_LAST) {
     MaterialDesignDisplayProperty material_property =
static_cast<MaterialDesignDisplayProperty>(id);
      ...
  }
  ...
}

[jonross, 2015/07/03 17:09:31]

These might remain after we complete the implementation and remove the current
defaults. We plan to test a normal Material Design layout, along with one for
touch centric CrOS devices.

I can move these values to their own enum, however we will still be switching in
GetDefaultDisplayProperties based on the current mode of the
MaterialDesignController. So it is not just a direct switch->if change.

+    PROPERTY_TOOLBAR_VIEW_LEFT_EDGE_SPACING,
+    PROPERTY_TOOLBAR_VIEW_RIGHT_EDGE_SPACING,
+    PROPERTY_TOOLBAR_VIEW_CONTENT_SHADOW_HEIGHT_ASH,
+    PROPERTY_TOOLBAR_VIEW_CONTENT_SHADOW_HEIGHT,
   };
 
   // Used by the browser theme pack to parse alignments from something like