ToolbarView MaterialDesign in ThemeProvider

chrome/browser/themes/theme_properties.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/themes/theme_properties.h"
 
+#include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "chrome/browser/themes/browser_theme_pack.h"
+#include "chrome/common/chrome_switches.h"
 #include "grit/theme_resources.h"
 #include "ui/resources/grit/ui_resources.h"
 
 namespace {
 
 // ----------------------------------------------------------------------------
 // Defaults for properties which are stored in the browser theme pack. If you
 // change these defaults, you must increment the version number in
 // browser_theme_pack.h
 
@@ skipping 68 matching lines @@
 #if defined(OS_MACOSX)
 const SkColor kDefaultColorToolbarButtonStroke = SkColorSetARGB(75, 81, 81, 81);
 const SkColor kDefaultColorToolbarButtonStrokeInactive =
     SkColorSetARGB(75, 99, 99, 99);
 const SkColor kDefaultColorToolbarBezel = SkColorSetRGB(204, 204, 204);
 const SkColor kDefaultColorToolbarStroke = SkColorSetRGB(103, 103, 103);
 const SkColor kDefaultColorToolbarStrokeInactive = SkColorSetRGB(163, 163, 163);
 #endif
 
 // ----------------------------------------------------------------------------
+// Defaults for layout properties, which are not stored in the browser theme
+// pack.
+
+// The edge graphics have some built-in spacing/shadowing, so we have to adjust
+// our spacing to make it match.
+const int kToolbarViewLeftEdgeSpacing = 3;
+const int kToolbarViewRightEdgeSpacing = 2;
+
+// Ash doesn't use a rounded content area and its top edge has an extra shadow.
+const int kToolbarViewContentShadowHeightAsh = 2;
+
+// Non-ash uses a rounded content area with no shadow in the assets.
+const int kToolbarViewContentShadowHeight = 0;
+
+#if defined(ENABLE_TOPCHROME_MD)
+const int kToolbarViewLeftEdgeSpacingMD = 8;

[tdanderson, 2015/06/09 15:32:38]

For readability and accounting purposes, I'm tempted to suggest dropping the
check for the compile-time flag here and just formatting this section as:

// Description of value.
const int kValue = 3;
const int kValueMD = 5;

// Description of value.
...

[jonross, 2015/06/10 14:09:03]

I personally prefer the compiler check. It acts as a grouping delimiter. However
I dislike the current lack of descriptions.

+const int kToolbarViewRightEdgeSpacingMD = 4;
+const int kToolbarViewContentShadowHeightAshMD = 0;
+const int kToolbarViewContentShadowHeightMD = 0;
+#endif
+
+// ----------------------------------------------------------------------------
 
 // Strings used in alignment properties.
 const char kAlignmentCenter[] = "center";
 const char kAlignmentTop[] = "top";
 const char kAlignmentBottom[] = "bottom";
 const char kAlignmentLeft[] = "left";
 const char kAlignmentRight[] = "right";
 
 // Strings used in background tiling repetition properties.
 const char kTilingNoRepeat[] = "no-repeat";
@@ skipping 19 matching lines @@
   IDR_BROWSER_ACTIONS_OVERFLOW_P,
   IDR_TOOLS, IDR_TOOLS_H, IDR_TOOLS_P,
   IDR_MENU_DROPARROW,
   IDR_TOOLBAR_BEZEL_HOVER, IDR_TOOLBAR_BEZEL_PRESSED, IDR_TOOLS_BAR,
 };
 
 SkColor TintForUnderline(SkColor input) {
   return SkColorSetA(input, SkColorGetA(input) / 3);
 }
 
+#if defined(ENABLE_TOPCHROME_MD)
+int GetMaterialDefaultDisplayProperty(int id) {
+  switch (id) {
+    case ThemeProperties::PROPERTY_TOOLBAR_VIEW_LEFT_EDGE_SPACING:
+      return kToolbarViewLeftEdgeSpacingMD;
+    case ThemeProperties::PROPERTY_TOOLBAR_VIEW_RIGHT_EDGE_SPACING:
+      return kToolbarViewRightEdgeSpacingMD;
+    case ThemeProperties::PROPERTY_TOOLBAR_VIEW_CONTENT_SHADOW_HEIGHT_ASH:
+      return kToolbarViewContentShadowHeightAshMD;
+    case ThemeProperties::PROPERTY_TOOLBAR_VIEW_CONTENT_SHADOW_HEIGHT:
+      return kToolbarViewContentShadowHeightMD;
+  }
+
+  return -1;

[tdanderson, 2015/06/09 15:32:38]

This will be a problem if any of our constants are actually equal to -1.

[tdanderson, 2015/06/09 17:50:07]

An example of a negative layout constant is kTabHorizontalOffset:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[jonross, 2015/06/10 14:09:03]

I've moved away from this.

I've pulled the old parameters out into a separate method, and have the MD call
it for the default case.

+}
+#endif
+
 }  // namespace
 
 // static
 int ThemeProperties::StringToAlignment(const std::string& alignment) {
   std::vector<std::string> split;
   base::SplitStringAlongWhitespace(alignment, &split);
 
   int alignment_mask = 0;
   for (std::vector<std::string>::iterator component(split.begin());
        component != split.end(); ++component) {
@@ skipping 144 matching lines @@
       return kDefaultColorToolbarStrokeInactive;
 #endif
     default:
       // Return a debugging red color.
       return SK_ColorRED;
   }
 }
 
 // static
 int ThemeProperties::GetDefaultDisplayProperty(int id) {
+#if defined(ENABLE_TOPCHROME_MD)
+  bool material_design_enabled =
+      base::CommandLine::ForCurrentProcess()->HasSwitch(
+          switches::kTopChromeMDEnabled);
+  if (material_design_enabled) {
+    int property = GetMaterialDefaultDisplayProperty(id);
+    if (property != -1)
+      return property;
+  }
+#endif
+
   switch (id) {
     case NTP_BACKGROUND_ALIGNMENT:
       return kDefaultDisplayPropertyNTPAlignment;
     case NTP_BACKGROUND_TILING:
       return kDefaultDisplayPropertyNTPTiling;
     case NTP_LOGO_ALTERNATE:
       return kDefaultDisplayPropertyNTPAlternateLogo;
+    case PROPERTY_TOOLBAR_VIEW_LEFT_EDGE_SPACING:
+      return kToolbarViewLeftEdgeSpacing;
+    case PROPERTY_TOOLBAR_VIEW_RIGHT_EDGE_SPACING:
+      return kToolbarViewRightEdgeSpacing;
+    case PROPERTY_TOOLBAR_VIEW_CONTENT_SHADOW_HEIGHT_ASH:
+      return kToolbarViewContentShadowHeightAsh;
+    case PROPERTY_TOOLBAR_VIEW_CONTENT_SHADOW_HEIGHT:
+      return kToolbarViewContentShadowHeight;
   }
 
   return -1;
 }