Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1164323002: Fixup Sky and Mojo dart pkg's exported mojoms (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fixup Sky and Mojo dart pkg's exported mojoms This populates each package's lib/mojom directory with the generated .mojom.dart files. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0f2414404a22666bd75d08650ad767139d7fb7c8

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M mojo/public/dart/BUILD.gn View 1 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/public/tools/dart_list_mojoms.py View 1 chunk +3 lines, -1 line 0 comments Download
M sky/sdk/BUILD.gn View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 6 months ago (2015-06-08 18:39:56 UTC) #2
eseidel
lgtm https://codereview.chromium.org/1164323002/diff/1/mojo/public/dart/BUILD.gn File mojo/public/dart/BUILD.gn (right): https://codereview.chromium.org/1164323002/diff/1/mojo/public/dart/BUILD.gn#newcode52 mojo/public/dart/BUILD.gn:52: "../../services/accessibility/public/interfaces", Should this just be a dependency moved ...
5 years, 6 months ago (2015-06-08 19:22:23 UTC) #3
Cutch
https://codereview.chromium.org/1164323002/diff/1/mojo/public/dart/BUILD.gn File mojo/public/dart/BUILD.gn (right): https://codereview.chromium.org/1164323002/diff/1/mojo/public/dart/BUILD.gn#newcode52 mojo/public/dart/BUILD.gn:52: "../../services/accessibility/public/interfaces", On 2015/06/08 19:22:23, eseidel wrote: > Should this ...
5 years, 6 months ago (2015-06-08 19:47:51 UTC) #4
Cutch
5 years, 6 months ago (2015-06-08 19:48:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
0f2414404a22666bd75d08650ad767139d7fb7c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698